[feature] provide [%uncurry: < x : int ; y : int > Js.t ] syntactic sugar
#388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note that keep in mind when we write ppx, do our best to not break |
kevinbarabash
pushed a commit
to kevinbarabash/rescript-compiler
that referenced
this pull request
Dec 24, 2021
Fixes rescript-lang#388 Somehow a stale package-lock.json was incrementally generated during 8748fa0, without the needed `hasInstallScript` field. CI still worked because CI was on an older npm which required regenerating the lockfile fresh. Lessons: - Be fast enough to generate something fresh please. - Go was right. No lockfiles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and some refactoring