Skip to content

POC: merging syntax repo #5268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

POC: merging syntax repo #5268

wants to merge 1 commit into from

Conversation

bobzhang
Copy link
Member

@bobzhang bobzhang commented Aug 31, 2021

Things to do:

  • Build needed targets in napkin parser for testing
  • Move test cases here

cc @IwanKaramazow, would you list the needed targets for testing, I can add it to the build system
If you have some better ideas to do it, feel free to take over this PR

@IwanKaramazow
Copy link

IwanKaramazow commented Sep 6, 2021

The test suite contains:

test.sh contains:

Every file in (https://github.com/rescript-lang/syntax/tree/master/tests) is necessary to provide full coverage of the current supported language.

I currently don't have any better ideas aside from copying the full repo and updating the makefile to point to the correct rescript-compiler files.

@kevinbarabash
Copy link
Contributor

It would be nice to keep the full history of files that get copied over. For that reason it might make sense to do this in two PRs:

  • simply copy files (with history) while maintaining the same workflow
  • update the makefile, merge package.json files, move .github/workflows/ci.yml to the right location, etc.

@kevinbarabash kevinbarabash mentioned this pull request Dec 24, 2021
1 task
@cristianoc
Copy link
Collaborator

@tsnobip you were interested in making progressi on this?

@cristianoc
Copy link
Collaborator

Though so many things have changed -- closing this as there would be little to salvage.

@cristianoc cristianoc closed this Jul 14, 2022
@cristianoc cristianoc deleted the vendor_syntax branch July 21, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants