Skip to content

Remove templates #5685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2022
Merged

Remove templates #5685

merged 2 commits into from
Sep 24, 2022

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Sep 22, 2022

This removes the templates and the rescript init command as discussed in #5682.

@cknitt cknitt linked an issue Sep 22, 2022 that may be closed by this pull request
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there anything in the "rescript" file itself?
Or does it take sub commands from the executable?

@cknitt
Copy link
Member Author

cknitt commented Sep 22, 2022

Yes, I forgot that one, another commit coming soon. 😄

@cristianoc
Copy link
Collaborator

Yes, I forgot that one, another commit coming soon. 😄

Merge away when done.

@cknitt cknitt marked this pull request as ready for review September 24, 2022 09:03
@cknitt cknitt merged commit 8b57da6 into rescript-lang:master Sep 24, 2022
@cknitt cknitt deleted the remove-templates branch September 24, 2022 09:15
cristianoc pushed a commit that referenced this pull request Oct 1, 2022
* Remove templates

* Remove init subcommand from script
@DZakh
Copy link
Member

DZakh commented Oct 14, 2022

Should also remove rescript init mentioning from the landing page.

https://github.com/rescript-association/rescript-lang.org/blob/b0da61146a0718337957e79569b5386220d55f93/src/layouts/LandingPageLayout.res#L246-L248

It probably makes sense to do it right now, without waiting for a rescript release, because I've recently tried using it, and it was a disaster.

cristianoc pushed a commit to d4h0/rescript-compiler that referenced this pull request Oct 27, 2022
* Remove templates

* Remove init subcommand from script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove templates
3 participants