Skip to content

cleanup jscomp/test #6910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

cometkim
Copy link
Member

by mostly removing empty test files, outdated, dangling files.

by mostly removing empty test files, outdated, dangling files.
@cometkim cometkim requested a review from cristianoc July 24, 2024 19:20
@cometkim cometkim merged commit 4217259 into rescript-lang:master Jul 24, 2024
19 checks passed
@cometkim cometkim deleted the meaningless-tests branch July 24, 2024 21:11
@cknitt
Copy link
Member

cknitt commented Jul 26, 2024

The empty .resi files were probably there on purpose so that no unnecessary exports are generated?
Not sure if that matters much though.

@cometkim
Copy link
Member Author

I reviewed all and left other resi files if it was understandable

@cometkim
Copy link
Member Author

jscomp/test files are still meaningful for regressions, but at the same time, many files are outdated or running unnecessarily, too. We need to consider a better testing strategy for the entire codebase (both ocaml/js). I'll try soon

@cknitt
Copy link
Member

cknitt commented Jul 26, 2024

Ah, right, it's a bit weird, not all of these files have test code that is actually executed (Mt.from_pair_suites(__MODULE__, suites))?

Then it is good to remove the .resi so that we at least can see all generated code. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants