Skip to content

Commit 1427686

Browse files
committed
SI-9277 Downgrade marginal javap features
Drop Java 6 support, -fun, -app, and -raw options.
1 parent fd526c7 commit 1427686

File tree

11 files changed

+132
-583
lines changed

11 files changed

+132
-583
lines changed

src/repl/scala/tools/nsc/interpreter/ILoop.scala

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -275,8 +275,7 @@ class ILoop(in0: Option[BufferedReader], protected val out: JPrintWriter)
275275
}
276276
}
277277

278-
protected def newJavap() =
279-
JavapClass(addToolsJarToLoader(), new IMain.ReplStrippingWriter(intp), Some(intp))
278+
protected def newJavap() = JavapClass(addToolsJarToLoader(), new IMain.ReplStrippingWriter(intp), intp)
280279

281280
private lazy val javap = substituteAndLog[Javap]("javap", NoJavap)(newJavap())
282281

@@ -315,7 +314,7 @@ class ILoop(in0: Option[BufferedReader], protected val out: JPrintWriter)
315314
if (javap == null)
316315
s":javap unavailable, no tools.jar at $jdkHome. Set JDK_HOME."
317316
else if (line == "")
318-
":javap [-lcsvp] [path1 path2 ...]"
317+
Javap.helpText
319318
else
320319
javap(words(line)) foreach { res =>
321320
if (res.isError) return s"Failed: ${res.value}"

src/repl/scala/tools/nsc/interpreter/JavapClass.scala

Lines changed: 127 additions & 473 deletions
Large diffs are not rendered by default.

test/files/run/repl-javap-def.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import scala.tools.partest.JavapTest
33
object Test extends JavapTest {
44
def code = """
55
|def f = 7
6-
|:javap -public -raw f
6+
|:javap -public f
77
""".stripMargin
88

99
// it should find f wrapped in repl skins. replstiltskin.

test/files/run/repl-javap-fun.scala

Lines changed: 0 additions & 16 deletions
This file was deleted.

test/files/run/repl-javap-lambdas.scala

Lines changed: 0 additions & 23 deletions
This file was deleted.

test/files/run/repl-javap-memfun.scala

Lines changed: 0 additions & 22 deletions
This file was deleted.

test/files/run/repl-javap-more-fun.scala

Lines changed: 0 additions & 17 deletions
This file was deleted.

test/files/run/repl-javap-outdir-funs.flags

Lines changed: 0 additions & 1 deletion
This file was deleted.

test/files/run/repl-javap-outdir-funs/foo_1.scala

Lines changed: 0 additions & 6 deletions
This file was deleted.

test/files/run/repl-javap-outdir-funs/run-repl_7.scala

Lines changed: 0 additions & 20 deletions
This file was deleted.

test/files/run/repl-javap.scala

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ object Test extends JavapTest {
77
""".stripMargin
88

99
override def yah(res: Seq[String]) = {
10-
def filtered = res filter (_ contains "public class Betty")
10+
val r = """public class \S*Betty""".r.unanchored
11+
def filtered = res filter { case r(_*) => true ; case _ => false }
1112
1 == filtered.size
1213
}
1314
}

0 commit comments

Comments
 (0)