Skip to content

Commit 0a379df

Browse files
committed
Fix multiple subscription bug on operation filter
A new subscription must be created on every subscribe call, otherwise any subscribe call after the first directly fails.
1 parent 69e0d99 commit 0a379df

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

rxjava-core/src/main/java/rx/operators/OperationFilter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,14 +37,14 @@ private static class Filter<T> implements Func1<Observer<T>, Subscription> {
3737

3838
private final Observable<T> that;
3939
private final Func1<T, Boolean> predicate;
40-
private final AtomicObservableSubscription subscription = new AtomicObservableSubscription();
4140

4241
public Filter(Observable<T> that, Func1<T, Boolean> predicate) {
4342
this.that = that;
4443
this.predicate = predicate;
4544
}
4645

4746
public Subscription call(final Observer<T> observer) {
47+
final AtomicObservableSubscription subscription = new AtomicObservableSubscription();
4848
return subscription.wrap(that.subscribe(new Observer<T>() {
4949
public void onNext(T value) {
5050
try {

0 commit comments

Comments
 (0)