Add guards around log statements

mttkay · mttkay · commit cf198bc3fb83 · 2013-10-14T10:23:18.000+02:00
diff --git a/rxjava-contrib/rxjava-android/src/main/java/rx/operators/OperationObserveFromAndroidComponent.java b/rxjava-contrib/rxjava-android/src/main/java/rx/operators/OperationObserveFromAndroidComponent.java
@@ -61,9 +61,11 @@ private OnSubscribeBase(Observable<T> source, AndroidComponent component) {
         }
 
         private void log(String message) {
-            Log.d(LOG_TAG, "componentRef = " + componentRef);
-            Log.d(LOG_TAG, "observerRef = " + observerRef);
-            Log.d(LOG_TAG, message);
+            if (Log.isLoggable(LOG_TAG, Log.DEBUG)) {
+                Log.d(LOG_TAG, "componentRef = " + componentRef);
+                Log.d(LOG_TAG, "observerRef = " + observerRef);
+                Log.d(LOG_TAG, message);
+            }
         }
 
         protected abstract boolean isComponentValid(AndroidComponent component);

Original file line number	Diff line number	Diff line change
`@@ -61,9 +61,11 @@ private OnSubscribeBase(Observable<T> source, AndroidComponent component) {`
`61`	`61`	`}`
`62`	`62`
`63`	`63`	`private void log(String message) {`
`64`		`- Log.d(LOG_TAG, "componentRef = " + componentRef);`
`65`		`- Log.d(LOG_TAG, "observerRef = " + observerRef);`
`66`		`- Log.d(LOG_TAG, message);`
	`64`	`+ if (Log.isLoggable(LOG_TAG, Log.DEBUG)) {`
	`65`	`+ Log.d(LOG_TAG, "componentRef = " + componentRef);`
	`66`	`+ Log.d(LOG_TAG, "observerRef = " + observerRef);`
	`67`	`+ Log.d(LOG_TAG, message);`
	`68`	`+ }`
`67`	`69`	`}`
`68`	`70`
`69`	`71`	`protected abstract boolean isComponentValid(AndroidComponent component);`