Fix 🐛 by using 3rd-party (properly tested) wildcard-match library (#323)

Author: robvanderleek

README.md

@@ -58,6 +58,8 @@ jobs:
             GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 ```
 
+*The latest GitHub Marketplace release is not always up-to-date (due to [this](https://i.8713187.xyzmunity/t/automatically-publish-action-to-marketplace-on-release/17978)). To have access to all features please use version `@master`*
+
 ### GitHub Action output variable
 
 The GitHub Action has one output variable: `branchName`, which contains the name of the branch that was created. You can use this output in downstream actions. For a trivial example see [this workflow](https://github.com/robvanderleek/robvanderleek.github.io/blob/2af5f90d94d81e942382892a6b6149467184b38b/.github/workflows/issue-branch.yml).

package.json

@@ -27,7 +27,8 @@
     "aws-sdk": "^2.824.0",
     "bunyan-sentry-stream": "^1.2.1",
     "probot": "^10.17.3",
-    "probot-actions-adapter": "^2.0.0"
+    "probot-actions-adapter": "^2.0.0",
+    "wildcard-match": "^5.1.0"
   },
   "devDependencies": {
     "@vercel/ncc": "^0.26",

src/utils.js

@@ -1,4 +1,5 @@
 const AWS = require('aws-sdk')
+const wcMatch = require('wildcard-match')
 
 function makePrefixGitSafe (s) {
   const regexp = /(?![-/])[\W]+/g
@@ -41,8 +42,8 @@ function interpolate (s, obj) {
 }
 
 function wildcardMatch (pattern, s) {
-  const regExp = new RegExp('^' + pattern.replace(/\*/g, '.*').replace(/\?/g, '.') + '$')
-  return regExp.test(s)
+  const isMatch = wcMatch(pattern, false)
+  return isMatch(s)
 }
 
 function isProduction () {

tests/probot-configuration.test.js

@@ -255,6 +255,30 @@ test('configuration with label branch and prefix', async () => {
   expect(targetRef).toBe('refs/heads/feature/issue-1-Test_issue')
 })
 
+test('issue #322 configuration', async () => {
+  helpers.nockNonExistingBranch('feature/issue-1-Test_issue')
+  helpers.nockExistingBranch('master', '12345678')
+  helpers.nockBranchCreatedComment()
+  const ymlConfig = `branches:
+  - label: 'type | bug'
+    prefix: bug/
+  - label: 'type | feature'
+    prefix: feature/`
+  helpers.nockConfig(ymlConfig)
+  let targetRef = ''
+
+  nock('https://api.github.com')
+    .post('/repos/robvanderleek/create-issue-branch/git/refs', (body) => {
+      targetRef = body.ref
+      return true
+    })
+    .reply(200)
+
+  await probot.receive({ name: 'issues', payload: helpers.issueAssignedWithLabelsPayload('type | feature') })
+
+  expect(targetRef).toBe('refs/heads/feature/issue-1-Test_issue')
+})
+
 test('configuration with label field missing', async () => {
   const ymlConfig = `branches:
   - name: dev

tests/utils.test.js

@@ -74,6 +74,9 @@ test('wildcard matching', () => {
   expect(utils.wildcardMatch('aap', 'aapnoot')).toBeFalsy()
   expect(utils.wildcardMatch('noot', 'aapnoot')).toBeFalsy()
   expect(utils.wildcardMatch('aap', 'Aap')).toBeFalsy()
+
+  expect(utils.wildcardMatch('aap*', 'aap/bar/noot')).toBeTruthy()
+  expect(utils.wildcardMatch('type | bug', 'type | feature')).toBeFalsy()
 })
 
 test('is running in GitHub Actions', () => {

yarn.lock

@@ -6562,6 +6562,11 @@ widest-line@^3.1.0:
   dependencies:
     string-width "^4.0.0"
 
+wildcard-match@^5.1.0:
+  version "5.1.0"
+  resolved "https://registry.yarnpkg.com/wildcard-match/-/wildcard-match-5.1.0.tgz#cb9d0c54a8bde298e534054146f3577f9e7b3c97"
+  integrity sha512-Q02fSwOl4xPEyLLMs3TiAOBD735ELrdiczcCnvYAn5VRDAycmzYzc69BmWI1MGONfngCSq+5mgIaYMoGfICqQg==
+
 word-wrap@^1.2.3, word-wrap@~1.2.3:
   version "1.2.3"
   resolved "https://registry.yarnpkg.com/word-wrap/-/word-wrap-1.2.3.tgz#610636f6b1f703891bd34771ccb17fb93b47079c"