Skip to content
This repository was archived by the owner on Nov 5, 2023. It is now read-only.

Commit fac9109

Browse files
committed
refactor: improve the typing of template refs
1 parent c05f1ab commit fac9109

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/Grid.vue

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,19 +76,19 @@ export default defineComponent({
7676
// endregion
7777
7878
// region: refs
79-
const rootRef = ref<HTMLElement>(document.createElement("div"));
80-
const probeRef = ref<HTMLElement>(document.createElement("div"));
79+
const rootRef = ref<Element>(document.createElement("div"));
80+
const probeRef = ref<Element>(document.createElement("div"));
8181
// endregion
8282
8383
// region: rendering triggers
8484
// a stream of root elements when scrolling
8585
// @ts-expect-error Rxjs has a typing bug on fromEvent() with resultSelector
8686
// which is fixed in https://github.com/ReactiveX/rxjs/pull/6447
87-
const scroll$: Observable<HTMLElement> = fromEventPattern(onMounted).pipe(
87+
const scroll$: Observable<Element> = fromEventPattern(onMounted).pipe(
8888
// use share() to push the "mounted" event from vue, instead of pulling:
8989
share(),
9090
switchMapTo(
91-
fromEvent<UIEvent, HTMLElement>(
91+
fromEvent<UIEvent, Element>(
9292
window,
9393
"scroll",
9494
{

src/pipeline.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ export function pipeline(
225225
pageProvider$: Observable<PageProvider>,
226226
pageSize$: Observable<number>,
227227
rootResize$: Observable<Element>,
228-
scroll$: Observable<HTMLElement>
228+
scroll$: Observable<Element>
229229
): PipelineOutput {
230230
// region: measurements of the visual grid
231231
const heightAboveWindow$: Observable<number> = merge(

0 commit comments

Comments
 (0)