Address clippy feedback

Author: esteve

examples/minimal_client_service/src/minimal_client.rs

@@ -8,9 +8,7 @@ fn main() -> Result<(), Error> {
 
     let client = node.create_client::<example_interfaces::srv::AddTwoInts>("add_two_ints")?;
 
-    let mut request = example_interfaces::srv::AddTwoInts_Request::default();
-    request.a = 41;
-    request.b = 1;
+    let request = example_interfaces::srv::AddTwoInts_Request { a: 41, b: 1 };
 
     println!("Starting client");
 

examples/minimal_client_service/src/minimal_client_async.rs

@@ -8,9 +8,7 @@ fn main() -> Result<(), Error> {
 
     let client = node.create_client::<example_interfaces::srv::AddTwoInts>("add_two_ints")?;
 
-    let mut request = example_interfaces::srv::AddTwoInts_Request::default();
-    request.a = 41;
-    request.b = 1;
+    let request = example_interfaces::srv::AddTwoInts_Request {a: 41, b: 1};
 
     println!("Starting client");
 
@@ -19,7 +17,7 @@ fn main() -> Result<(), Error> {
     let future = client.call_async(&request)?;
 
     println!("Waiting for response");
-    let response = rclrs::spin_until_future_complete(&node, future.clone())?;
+    let response = rclrs::spin_until_future_complete(&node, future)?;
 
     println!(
         "Result of {} + {} is: {}",

rclrs/src/future.rs

@@ -1,6 +1,5 @@
 /// Based on https://www.viget.com/articles/understanding-futures-in-rust-part-1/
 use std::future::Future;
-use std::marker::PhantomData;
 use std::pin::Pin;
 use std::sync::Arc;
 use std::task::Context;
@@ -9,8 +8,6 @@ use std::task::RawWaker;
 use std::task::RawWakerVTable;
 use std::task::Waker;
 
-use parking_lot::Mutex;
-
 #[derive(Default)]
 pub struct RclFuture<T> {
     value: Option<T>,

rclrs/src/lib.rs

@@ -115,7 +115,7 @@ pub fn spin(node: &Node) -> Result<(), RclrsError> {
 
 pub fn spin_until_future_complete<T: Unpin + Clone>(
     node: &node::Node,
-    mut future: Arc<Mutex<Box<crate::future::RclFuture<T>>>>,
+    future: Arc<Mutex<Box<crate::future::RclFuture<T>>>>,
 ) -> Result<<future::RclFuture<T> as Future>::Output, RclrsError> {
     let rclwaker = Arc::new(crate::future::RclWaker {});
     let waker = crate::future::rclwaker_into_waker(Arc::into_raw(rclwaker));

rclrs/src/node/client.rs

@@ -1,3 +1,4 @@
+#![warn(missing_docs)]
 use std::borrow::Borrow;
 use std::boxed::Box;
 use std::collections::HashMap;
@@ -229,7 +230,7 @@ where
         let futures = &mut *self.futures.lock();
         if requests.contains_key(&req_id.sequence_number) {
             let callback = requests.remove(&req_id.sequence_number).unwrap();
-            (&mut *callback.lock())(&res);
+            (*callback.lock())(&res);
         } else if futures.contains_key(&req_id.sequence_number) {
             let future = futures.remove(&req_id.sequence_number).unwrap();
             (&mut *future.lock()).set_value(res);

rclrs/src/node/service.rs

@@ -148,7 +148,7 @@ where
             Err(e) => return Err(e),
         };
         let mut res = T::Response::default();
-        (&mut *self.callback.lock())(&req_id, &req, &mut res);
+        (*self.callback.lock())(&req_id, &req, &mut res);
         let rmw_message = <T::Response as Message>::into_rmw_message(res.into_cow());
         let handle = &mut *self.handle.lock();
         let ret = unsafe {

rosidl_runtime_rs/src/traits.rs

@@ -1,3 +1,4 @@
+#![warn(missing_docs)]
 // Copyright 2020 DCS Corporation, All Rights Reserved.
 
 // Licensed under the Apache License, Version 2.0 (the "License");