Replace constructor method procedure

For backward compatibility, it is better to retain constructor method
but deperecated.
As for now, constructors only use NodeBuilder.

Author: Soya-Onishi

rclrs/src/context.rs

@@ -1,5 +1,5 @@
 use crate::rcl_bindings::*;
-use crate::{Node, RclReturnCode, ToResult};
+use crate::{Node, NodeBuilder, RclReturnCode, ToResult};
 
 use std::ffi::CString;
 use std::os::raw::c_char;
@@ -111,7 +111,7 @@ impl Context {
     /// assert!(node.is_ok());
     /// ```
     pub fn create_node(&self, node_name: &str) -> Result<Node, RclReturnCode> {
-        Node::new(node_name, self)
+        NodeBuilder::new(node_name, self).build()
     }
 
     /// Creates a node in a namespace.
@@ -132,7 +132,24 @@ impl Context {
         node_namespace: &str,
         node_name: &str,
     ) -> Result<Node, RclReturnCode> {
-        Node::new_with_namespace(node_namespace, node_name, self)
+        NodeBuilder::new(node_name, self)
+            .namespace(node_namespace)
+            .build()
+    }
+
+    /// Creates a [`NodeBuilder`][1]
+    ///
+    /// [1]: crate::NodeBuilder
+    ///
+    /// # Example
+    /// ```
+    /// # use rclrs::Context;
+    /// let ctx = Context::new([]).unwrap();
+    /// let builder = ctx.node_builder("foo_node");
+    /// let node = builder.build();
+    /// ```
+    pub fn create_node_builder<'a>(&'a self, node_name: &'a str) -> NodeBuilder<'a> {
+        NodeBuilder::new(node_name, self)
     }
 
     /// Checks if the context is still valid.

rclrs/src/node/mod.rs

@@ -64,51 +64,25 @@ pub struct NodeBuilder<'a> {
 
 impl Node {
     /// Creates a new node in the empty namespace.
+    #[deprecated(since = "0.2.0", note = "please use `NodeBuilder` instead")]
     #[allow(clippy::new_ret_no_self)]
     pub fn new(node_name: &str, context: &Context) -> Result<Node, RclReturnCode> {
-        Self::new_with_namespace("", node_name, context)
+        NodeBuilder::new(node_name, context).build()
     }
 
     /// Creates a new node in a namespace.
     ///
     /// A namespace without a leading forward slash is automatically changed to have a leading
     /// forward slash.
+    #[deprecated(since = "0.2.0", note = "please use `NodeBuilder` instead")]
     pub fn new_with_namespace(
         node_ns: &str,
         node_name: &str,
         context: &Context,
     ) -> Result<Node, RclReturnCode> {
-        let raw_node_name = CString::new(node_name).unwrap();
-        let raw_node_ns = CString::new(node_ns).unwrap();
-
-        // SAFETY: Getting a zero-initialized value is always safe.
-        let mut node_handle = unsafe { rcl_get_zero_initialized_node() };
-        let context_handle = &mut *context.handle.lock();
-
-        unsafe {
-            // SAFETY: No preconditions for this function.
-            let node_options = rcl_node_get_default_options();
-            // SAFETY: The node handle is zero-initialized as expected by this function.
-            // The strings and node options are copied by this function, so we don't need
-            // to keep them alive.
-            // The context handle is kept alive because it is co-owned by the node.
-            rcl_node_init(
-                &mut node_handle,
-                raw_node_name.as_ptr(),
-                raw_node_ns.as_ptr(),
-                context_handle,
-                &node_options,
-            )
-            .ok()?;
-        }
-
-        let handle = Arc::new(Mutex::new(node_handle));
-
-        Ok(Node {
-            handle,
-            context: context.handle.clone(),
-            subscriptions: std::vec![],
-        })
+        NodeBuilder::new(node_name, context)
+            .namespace(node_ns)
+            .build()
     }
 
     /// Returns the name of the node.