removes noargs reconnect() method

Signed-off-by: Oleh Dokuka <[email protected]>

Author: OlegDokuka

rsocket-core/src/main/java/io/rsocket/RSocketFactory.java

@@ -248,7 +248,7 @@ public ClientRSocketFactory singleSubscriberRequester() {
      *   RSocketFactory
      *                .connect()
      *                .singleSubscriberRequester()
-     *                .reconnect()
+     *                .reconnect(Retry.fixedDelay(3, Duration.ofSeconds(1)))
      *                .transport(transport)
      *                .start();
      *
@@ -260,7 +260,7 @@ public ClientRSocketFactory singleSubscriberRequester() {
      * }</pre>
      *
      * Apart of the shared behavior, once the previous connection has been expired (e.g. connection
-     * has been disposed), the same instance of {@code Mono<RSocket>} reestablish connection without
+     * has been disposed), the same instance of {@code Mono<RSocket>} reestablishes connection without
      * any extra effort. <br>
      * For example:
      *
@@ -269,7 +269,7 @@ public ClientRSocketFactory singleSubscriberRequester() {
      *   RSocketFactory
      *                .connect()
      *                .singleSubscriberRequester()
-     *                .reconnect()
+     *                .reconnect(Retry.fixedDelay(3, Duration.ofSeconds(1)))
      *                .transport(transport)
      *                .start();
      *
@@ -291,67 +291,7 @@ public ClientRSocketFactory singleSubscriberRequester() {
      *
      * }</pre>
      *
-     * @return a shared instance of {@code Mono<RSocket>}.
-     */
-    public ClientRSocketFactory reconnect() {
-      this.reconnectEnabled = true;
-      return this;
-    }
-
-    /**
-     * Enables a reconnectable, shared instance of {@code Mono<RSocket>} so every subscriber will
-     * observe the same RSocket instance up on connection establishment. <br>
-     * For example:
-     *
-     * <pre>{@code
-     * Mono<RSocket> sharedRSocketMono =
-     *   RSocketFactory
-     *                .connect()
-     *                .singleSubscriberRequester()
-     *                .reconnect(fluxOfThrowables -> flux.concatMap(t -> Mono.delay(Duration.ofSeconds(1)).take(5))
-     *                .transport(transport)
-     *                .start();
-     *
-     *  RSocket r1 = sharedRSocketMono.block();
-     *  RSocket r2 = sharedRSocketMono.block();
-     *
-     *  assert r1 == r2;
-     *
-     * }</pre>
-     *
-     * Apart of the shared behavior, once the previous connection has been expired (e.g. connection
-     * has been disposed), the same instance of {@code Mono<RSocket>} reestablish connection without
-     * any extra effort. <br>
-     * For example:
-     *
-     * <pre>{@code
-     * Mono<RSocket> sharedRSocketMono =
-     *   RSocketFactory
-     *                .connect()
-     *                .singleSubscriberRequester()
-     *                .reconnect(fluxOfThrowables -> flux.concatMap(t -> Mono.delay(Duration.ofSeconds(1)).take(5))
-     *                .transport(transport)
-     *                .start();
-     *
-     *  RSocket r1 = sharedRSocketMono.block();
-     *  RSocket r2 = sharedRSocketMono.block();
-     *
-     *  assert r1 == r2;
-     *
-     *  r1.dispose()
-     *
-     *  assert r2.isDisposed()
-     *
-     *  RSocket r3 = sharedRSocketMono.block();
-     *  RSocket r4 = sharedRSocketMono.block();
-     *
-     *
-     *  assert r1 != r3;
-     *  assert r4 == r3;
-     *
-     * }</pre>
-     *
-     * @param whenFactory a retry factory applied for {@link Mono.retryWhen(whenFactory)}
+     * @param retrySpec a retry factory applied for {@link Mono#retryWhen(Retry)}
      * @return a shared instance of {@code Mono<RSocket>}.
      */
     public ClientRSocketFactory reconnect(Retry retrySpec) {
@@ -527,7 +467,7 @@ public Mono<RSocket> start() {
                 source -> {
                   if (reconnectEnabled) {
                     return new ReconnectMono<>(
-                        retrySpec == null ? source : source.retryWhen(retrySpec),
+                        source.retryWhen(retrySpec),
                         Disposable::dispose,
                         INVALIDATE_FUNCTION);
                   } else {