Skip to content

Commit 5921ef3

Browse files
committed
moves validator to core package and makes it pkg private
Signed-off-by: Oleh Dokuka <[email protected]>
1 parent 4b047c7 commit 5921ef3

File tree

4 files changed

+19
-21
lines changed

4 files changed

+19
-21
lines changed

rsocket-core/src/main/java/io/rsocket/fragmentation/FragmentationUtils.java renamed to rsocket-core/src/main/java/io/rsocket/core/PayloadValidationUtils.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
package io.rsocket.fragmentation;
1+
package io.rsocket.core;
22

33
import io.netty.buffer.ByteBuf;
44
import io.rsocket.Payload;
55
import io.rsocket.frame.FrameHeaderFlyweight;
66
import io.rsocket.frame.FrameLengthFlyweight;
77

8-
public final class FragmentationUtils {
8+
final class PayloadValidationUtils {
99
public static boolean isValid(int mtu, Payload payload) {
1010
return payload.hasMetadata()
1111
? isValid(mtu, payload.data(), payload.metadata())

rsocket-core/src/main/java/io/rsocket/core/RSocketRequester.java

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
import io.rsocket.RSocket;
2929
import io.rsocket.exceptions.ConnectionErrorException;
3030
import io.rsocket.exceptions.Exceptions;
31-
import io.rsocket.fragmentation.FragmentationUtils;
3231
import io.rsocket.frame.CancelFrameFlyweight;
3332
import io.rsocket.frame.ErrorFrameFlyweight;
3433
import io.rsocket.frame.FrameHeaderFlyweight;
@@ -190,7 +189,7 @@ private Mono<Void> handleFireAndForget(Payload payload) {
190189
return Mono.error(err);
191190
}
192191

193-
if (!FragmentationUtils.isValid(this.mtu, payload)) {
192+
if (!PayloadValidationUtils.isValid(this.mtu, payload)) {
194193
payload.release();
195194
return Mono.error(
196195
new IllegalArgumentException(
@@ -221,7 +220,7 @@ private Mono<Payload> handleRequestResponse(final Payload payload) {
221220
return Mono.error(err);
222221
}
223222

224-
if (!FragmentationUtils.isValid(this.mtu, payload)) {
223+
if (!PayloadValidationUtils.isValid(this.mtu, payload)) {
225224
payload.release();
226225
return Mono.error(
227226
new IllegalArgumentException(
@@ -273,7 +272,7 @@ private Flux<Payload> handleRequestStream(final Payload payload) {
273272
return Flux.error(err);
274273
}
275274

276-
if (!FragmentationUtils.isValid(this.mtu, payload)) {
275+
if (!PayloadValidationUtils.isValid(this.mtu, payload)) {
277276
payload.release();
278277
return Flux.error(
279278
new IllegalArgumentException(
@@ -342,7 +341,7 @@ private Flux<Payload> handleChannel(Flux<Payload> request) {
342341
(s, flux) -> {
343342
Payload payload = s.get();
344343
if (payload != null) {
345-
if (!FragmentationUtils.isValid(mtu, payload)) {
344+
if (!PayloadValidationUtils.isValid(mtu, payload)) {
346345
payload.release();
347346
final IllegalArgumentException t =
348347
new IllegalArgumentException(
@@ -374,7 +373,7 @@ protected void hookOnSubscribe(Subscription subscription) {
374373

375374
@Override
376375
protected void hookOnNext(Payload payload) {
377-
if (!FragmentationUtils.isValid(mtu, payload)) {
376+
if (!PayloadValidationUtils.isValid(mtu, payload)) {
378377
payload.release();
379378
cancel();
380379
final IllegalArgumentException t =
@@ -472,7 +471,7 @@ private Mono<Void> handleMetadataPush(Payload payload) {
472471
return Mono.error(err);
473472
}
474473

475-
if (!FragmentationUtils.isValid(this.mtu, payload)) {
474+
if (!PayloadValidationUtils.isValid(this.mtu, payload)) {
476475
payload.release();
477476
return Mono.error(
478477
new IllegalArgumentException(

rsocket-core/src/main/java/io/rsocket/core/RSocketResponder.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import io.rsocket.RSocket;
2626
import io.rsocket.ResponderRSocket;
2727
import io.rsocket.exceptions.ApplicationErrorException;
28-
import io.rsocket.fragmentation.FragmentationUtils;
2928
import io.rsocket.frame.*;
3029
import io.rsocket.frame.decoder.PayloadDecoder;
3130
import io.rsocket.internal.SynchronizedIntObjectHashMap;
@@ -376,7 +375,7 @@ protected void hookOnNext(Payload payload) {
376375
isEmpty = false;
377376
}
378377

379-
if (!FragmentationUtils.isValid(mtu, payload)) {
378+
if (!PayloadValidationUtils.isValid(mtu, payload)) {
380379
payload.release();
381380
cancel();
382381
final IllegalArgumentException t =
@@ -432,7 +431,7 @@ protected void hookOnSubscribe(Subscription s) {
432431

433432
@Override
434433
protected void hookOnNext(Payload payload) {
435-
if (!FragmentationUtils.isValid(mtu, payload)) {
434+
if (!PayloadValidationUtils.isValid(mtu, payload)) {
436435
payload.release();
437436
cancel();
438437
final IllegalArgumentException t =

rsocket-core/src/test/java/io/rsocket/fragmentation/FragmentationUtilsTest.java renamed to rsocket-core/src/test/java/io/rsocket/core/PayloadValidationUtilsTest.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package io.rsocket.fragmentation;
1+
package io.rsocket.core;
22

33
import io.rsocket.Payload;
44
import io.rsocket.frame.FrameHeaderFlyweight;
@@ -8,7 +8,7 @@
88
import org.assertj.core.api.Assertions;
99
import org.junit.jupiter.api.Test;
1010

11-
class FragmentationUtilsTest {
11+
class PayloadValidationUtilsTest {
1212

1313
@Test
1414
void shouldBeValidFrameWithNoFragmentation() {
@@ -20,7 +20,7 @@ void shouldBeValidFrameWithNoFragmentation() {
2020
ThreadLocalRandom.current().nextBytes(data);
2121
final Payload payload = DefaultPayload.create(data);
2222

23-
Assertions.assertThat(FragmentationUtils.isValid(0, payload)).isTrue();
23+
Assertions.assertThat(PayloadValidationUtils.isValid(0, payload)).isTrue();
2424
}
2525

2626
@Test
@@ -34,7 +34,7 @@ void shouldBeInValidFrameWithNoFragmentation() {
3434
ThreadLocalRandom.current().nextBytes(data);
3535
final Payload payload = DefaultPayload.create(data);
3636

37-
Assertions.assertThat(FragmentationUtils.isValid(0, payload)).isFalse();
37+
Assertions.assertThat(PayloadValidationUtils.isValid(0, payload)).isFalse();
3838
}
3939

4040
@Test
@@ -50,7 +50,7 @@ void shouldBeValidFrameWithNoFragmentation0() {
5050
ThreadLocalRandom.current().nextBytes(metadata);
5151
final Payload payload = DefaultPayload.create(data, metadata);
5252

53-
Assertions.assertThat(FragmentationUtils.isValid(0, payload)).isTrue();
53+
Assertions.assertThat(PayloadValidationUtils.isValid(0, payload)).isTrue();
5454
}
5555

5656
@Test
@@ -61,7 +61,7 @@ void shouldBeInValidFrameWithNoFragmentation1() {
6161
ThreadLocalRandom.current().nextBytes(data);
6262
final Payload payload = DefaultPayload.create(data, metadata);
6363

64-
Assertions.assertThat(FragmentationUtils.isValid(0, payload)).isFalse();
64+
Assertions.assertThat(PayloadValidationUtils.isValid(0, payload)).isFalse();
6565
}
6666

6767
@Test
@@ -72,7 +72,7 @@ void shouldBeValidFrameWithNoFragmentation2() {
7272
ThreadLocalRandom.current().nextBytes(data);
7373
final Payload payload = DefaultPayload.create(data, metadata);
7474

75-
Assertions.assertThat(FragmentationUtils.isValid(0, payload)).isTrue();
75+
Assertions.assertThat(PayloadValidationUtils.isValid(0, payload)).isTrue();
7676
}
7777

7878
@Test
@@ -83,7 +83,7 @@ void shouldBeValidFrameWithNoFragmentation3() {
8383
ThreadLocalRandom.current().nextBytes(data);
8484
final Payload payload = DefaultPayload.create(data, metadata);
8585

86-
Assertions.assertThat(FragmentationUtils.isValid(64, payload)).isTrue();
86+
Assertions.assertThat(PayloadValidationUtils.isValid(64, payload)).isTrue();
8787
}
8888

8989
@Test
@@ -94,6 +94,6 @@ void shouldBeValidFrameWithNoFragmentation4() {
9494
ThreadLocalRandom.current().nextBytes(data);
9595
final Payload payload = DefaultPayload.create(data, metadata);
9696

97-
Assertions.assertThat(FragmentationUtils.isValid(64, payload)).isTrue();
97+
Assertions.assertThat(PayloadValidationUtils.isValid(64, payload)).isTrue();
9898
}
9999
}

0 commit comments

Comments
 (0)