Default errorConsumer to no-op in the new API

RSocketFactory retains its previous defaults but RSocketConnector and
RSocketServer now default to a no-op.

Signed-off-by: Rossen Stoyanchev <[email protected]>

Author: rstoyanchev

rsocket-core/src/main/java/io/rsocket/RSocketFactory.java

@@ -111,7 +111,7 @@ public static class ClientRSocketFactory implements ClientTransportAcceptor {
     private Resume resume;
 
     public ClientRSocketFactory() {
-      this(RSocketConnector.create());
+      this(RSocketConnector.create().errorConsumer(Throwable::printStackTrace));
     }
 
     public ClientRSocketFactory(RSocketConnector connector) {
@@ -393,6 +393,9 @@ public ClientRSocketFactory fragment(int mtu) {
       return this;
     }
 
+    /**
+     * @deprecated this is deprecated with no replacement.
+     */
     public ClientRSocketFactory errorConsumer(Consumer<Throwable> errorConsumer) {
       connector.errorConsumer(errorConsumer);
       return this;
@@ -416,7 +419,7 @@ public static class ServerRSocketFactory implements ServerTransportAcceptor {
     private Resume resume;
 
     public ServerRSocketFactory() {
-      this(RSocketServer.create());
+      this(RSocketServer.create().errorConsumer(Throwable::printStackTrace));
     }
 
     public ServerRSocketFactory(RSocketServer server) {
@@ -496,6 +499,9 @@ public ServerRSocketFactory fragment(int mtu) {
       return this;
     }
 
+    /**
+     * @deprecated this is deprecated with no replacement.
+     */
     public ServerRSocketFactory errorConsumer(Consumer<Throwable> errorConsumer) {
       server.errorConsumer(errorConsumer);
       return this;

rsocket-core/src/main/java/io/rsocket/core/RSocketConnector.java

@@ -69,7 +69,7 @@ public class RSocketConnector {
   private int mtu = 0;
   private PayloadDecoder payloadDecoder = PayloadDecoder.DEFAULT;
 
-  private Consumer<Throwable> errorConsumer = Throwable::printStackTrace;
+  private Consumer<Throwable> errorConsumer = ex -> {};
 
   private RSocketConnector() {}
 

rsocket-core/src/main/java/io/rsocket/core/RSocketServer.java

@@ -52,7 +52,7 @@ public final class RSocketServer {
   private Resume resume;
   private Supplier<Leases<?>> leasesSupplier = null;
 
-  private Consumer<Throwable> errorConsumer = Throwable::printStackTrace;
+  private Consumer<Throwable> errorConsumer = ex -> {};
   private PayloadDecoder payloadDecoder = PayloadDecoder.DEFAULT;
 
   private RSocketServer() {}