Empty Payload Response treated as Complete frame #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem `FrameHeaderFlyweight` resolves the frame type as `NEXT_COMPLETE` only if the payload is not empty. Otherwise, the frame is treated as `COMPLETE`. This is a problem for request-response as this means the response publisher will complete without emitting a response, if the response does not have any data. Such a condition is a failure as request-response should have exaclty one response. #### Modification Eliminated the check for data length and always emit `NEXT_COMPLETE` if the complete flag is set. According to the [protocol](https://github.com/ReactiveSocket/reactivesocket/blob/master/Protocol.md#response-frame): ``` A Response is generally referred to as a NEXT. ``` So, this behavior would not be a violation of the protocol but will produce empty `onNext` before `onComplete` #### Result Better behavior with empty responses.
robertroeser
approved these changes
Dec 12, 2016
NiteshKant
added a commit
to NiteshKant/reactivesocket-java
that referenced
this pull request
Dec 14, 2016
#### Problem `FrameHeaderFlyweight` resolves the frame type as `NEXT_COMPLETE` only if the payload is not empty. Otherwise, the frame is treated as `COMPLETE`. This is a problem for request-response as this means the response publisher will complete without emitting a response, if the response does not have any data. Such a condition is a failure as request-response should have exaclty one response. #### Modification Eliminated the check for data length and always emit `NEXT_COMPLETE` if the complete flag is set. According to the [protocol](https://github.com/ReactiveSocket/reactivesocket/blob/master/Protocol.md#response-frame): ``` A Response is generally referred to as a NEXT. ``` So, this behavior would not be a violation of the protocol but will produce empty `onNext` before `onComplete` #### Result Better behavior with empty responses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
FrameHeaderFlyweightresolves the frame type asNEXT_COMPLETEonly if the payload is not empty. Otherwise, the frame is treated asCOMPLETE.This is a problem for request-response as this means the response publisher will complete without emitting a response, if the response does not have any data. Such a condition is a failure as request-response should have exaclty one response.
Modification
Eliminated the check for data length and always emit
NEXT_COMPLETEif the complete flag is set.According to the protocol:
So, this behavior would not be a violation of the protocol but will produce empty
onNextbeforeonCompleteResult
Better behavior with empty responses.