Skip to content

Ensure sendProcessor is disposed #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2018
Merged

Ensure sendProcessor is disposed #508

merged 2 commits into from
Sep 17, 2018

Conversation

rdegnan
Copy link
Member

@rdegnan rdegnan commented May 21, 2018

No description provided.

@rdegnan rdegnan requested a review from robertroeser May 21, 2018 16:12
@nebhale
Copy link
Member

nebhale commented May 29, 2018

@rdegnan I’ve been tweaking the timeout of the 2M test, but it’s probably time to take it back to the way it was before my refactoring and @Dispose it. I believe that timeout is now at 2 minutes, which, if it can’t complete successfully in that time, is probably not useful to test regularly.

@rdegnan rdegnan force-pushed the fix-leaks branch 2 times, most recently from c4fdd9a to 319a061 Compare September 17, 2018 22:47
@rdegnan rdegnan merged commit 08705ea into rsocket:1.0.x Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants