perform profiling all the time to allow dynamically changing profile_examples option

Author: JonRowe

lib/rspec/core/configuration.rb

@@ -827,18 +827,6 @@ def profile_examples
         end
       end
 
-      # @private
-      def profiler
-        @profiler ||=
-          begin
-            if value_for(:profile_examples) { @profile_examples }
-              Profiler.new
-            else
-              NoProfiler
-            end
-          end
-      end
-
       # @private
       def files_or_directories_to_run=(*files)
         files = files.flatten

lib/rspec/core/profiler.rb

@@ -1,16 +1,5 @@
 module RSpec
   module Core
-    # @private
-    class NoProfiler
-      def self.notifications
-        []
-      end
-
-      def self.example_groups
-        {}
-      end
-    end
-
     # @private
     class Profiler
       NOTIFICATIONS = [:example_group_started, :example_group_finished, :example_started]
@@ -21,10 +10,6 @@ def initialize
 
       attr_reader :example_groups
 
-      def notifications
-        NOTIFICATIONS
-      end
-
       def example_group_started(notification)
         @example_groups[notification.group.id][:start] = Time.now
         @example_groups[notification.group.id][:description] = notification.group.top_level_description

lib/rspec/core/reporter.rb

@@ -18,7 +18,8 @@ def initialize(configuration)
       @failed_examples = []
       @pending_examples = []
       @duration = @start = @load_time = nil
-      register_listener @configuration.profiler, *@configuration.profiler.notifications
+      @profiler = Profiler.new
+      register_listener @profiler, *Profiler::NOTIFICATIONS
     end
 
     # @private
@@ -151,7 +152,7 @@ def finish
         unless mute_profile_output?
           notify :dump_profile, Notifications::ProfileNotification.new(@duration, @examples,
                                                                        @configuration.profile_examples,
-                                                                       @configuration.profiler)
+                                                                       @profiler)
         end
         notify :dump_summary, Notifications::SummaryNotification.new(@duration, @examples, @failed_examples,
                                                                      @pending_examples, @load_time)

spec/rspec/core/profiler_spec.rb

@@ -1,13 +1,5 @@
 require 'rspec/core/profiler'
 
-RSpec.describe 'RSpec::Core::NoProfiler' do
-  let(:no_profiler) { RSpec::Core::NoProfiler }
-
-  it 'has an empty hash of example_groups' do
-    expect(no_profiler.example_groups).to be_empty.and be_a Hash
-  end
-end
-
 RSpec.describe 'RSpec::Core::Profiler' do
   let(:profiler) { RSpec::Core::Profiler.new }
 

spec/support/formatter_support.rb

@@ -187,7 +187,6 @@ def setup_reporter(*streams)
 
   def setup_profiler
     config.profile_examples = true
-    config.profiler
   end
 
   def formatter_output
@@ -225,6 +224,7 @@ def new_example(metadata = {})
     instance_double(RSpec::Core::Example,
                      :description             => "Example",
                      :full_description        => "Example",
+                     :example_group           => group,
                      :execution_result        => result,
                      :location                => "",
                      :location_rerun_argument => "",
@@ -239,7 +239,9 @@ def examples(n)
   end
 
   def group
-    class_double "RSpec::Core::ExampleGroup", :description => "Group"
+    group = class_double "RSpec::Core::ExampleGroup", :description => "Group", id: 1
+    allow(group).to receive(:parent_groups) { [group] }
+    group
   end
 
   def start_notification(count)
@@ -279,7 +281,7 @@ def summary_notification(duration, examples, failed, pending, time)
   end
 
   def profile_notification(duration, examples, number)
-    ::RSpec::Core::Notifications::ProfileNotification.new duration, examples, number, config.profiler
+    ::RSpec::Core::Notifications::ProfileNotification.new duration, examples, number, reporter.instance_variable_get('@profiler')
   end
 
 end