Fix our specs

Author: pirj

spec/rspec/core/example_group_spec.rb

@@ -56,12 +56,12 @@ def metadata_hash(*args)
     end
 
     it 'does not treat the first argument as a metadata key even if it is a symbol' do
-      group = RSpec.describe(:symbol)
+      group = with_an_expected_warning { RSpec.describe(:symbol) }
       expect(group.metadata).not_to include(:symbol)
     end
 
     it 'treats the first argument as part of the description when it is a symbol' do
-      group = RSpec.describe(:symbol)
+      group = with_an_expected_warning { RSpec.describe(:symbol) }
       expect(group.description).to eq("symbol")
     end
 

spec/rspec/core/hooks_filtering_spec.rb

@@ -313,7 +313,7 @@ module RSpec::Core
           c.after(:each,  :match => false) { filters << "after each in config"}
           c.after(:all,   :match => false) { filters << "after all in config"}
         end
-        group = RSpec.describe(:match => true)
+        group = RSpec.describe('example group', :match => true)
         group.example("example") {}
         group.run
         expect(filters).to eq([])

spec/rspec/core/memoized_helpers_spec.rb

@@ -5,7 +5,7 @@ module RSpec::Core
     before(:each) { RSpec.configuration.configure_expectation_framework }
 
     def subject_value_for(describe_arg, &block)
-      example_group = RSpec.describe(describe_arg, &block)
+      example_group = with_an_expected_warning { RSpec.describe(describe_arg, &block) }
       subject_value = nil
       example_group.example { subject_value = subject }
       example_group.run
@@ -340,10 +340,16 @@ def not_ok?; false; end
       end
 
       it 'supports a new expect-based syntax' do
-        group = RSpec.describe([1, 2, 3]) do
-          it { is_expected.to be_an Array }
-          it { is_expected.not_to include 4 }
+        math_class = Class.new do
+          def easy?
+            false
+          end
         end
+        group =
+          RSpec.describe(math_class) do
+            it { is_expected.to be_a math_class }
+            it { is_expected.to_not be_easy }
+          end
 
         expect(group.run).to be true
       end

spec/rspec/core/metadata_spec.rb

@@ -381,24 +381,24 @@ def metadata_for(*args)
 
           context "with a String" do
             it "returns nil" do
-              expect(value_for "group").to be_nil
+              expect(value_for("group")).to be_nil
             end
           end
 
           context "with a Symbol" do
             it "returns the symbol" do
-              expect(value_for :group).to be(:group)
+              expect(with_an_expected_warning { value_for(:group) }).to be(:group)
             end
           end
 
           context "with a class" do
             it "returns the class" do
-              expect(value_for String).to be(String)
+              expect(value_for(String)).to be(String)
             end
 
             context "when the class is Regexp" do
               it "returns the class" do
-                expect(value_for Regexp).to be(Regexp)
+                expect(value_for(Regexp)).to be(Regexp)
               end
             end
           end
@@ -636,7 +636,7 @@ def group_value_for(*args)
         it "finds the first non-rspec lib file in the caller array" do
           value = nil
 
-          RSpec.describe(:caller => ["./lib/rspec/core/foo.rb", "#{__FILE__}:#{__LINE__}"]) do
+          RSpec.describe('example group', :caller => ["./lib/rspec/core/foo.rb", "#{__FILE__}:#{__LINE__}"]) do
             value = metadata[:file_path]
           end
 

spec/spec_helper.rb

@@ -62,6 +62,10 @@ def handle_current_dir_change
   ensure
     RSpec::Core::Metadata.instance_variable_set(:@relative_path_regex, nil)
   end
+
+  def with_an_expected_warning
+    with_isolated_stderr { yield }
+  end
 end
 
 RSpec.configure do |c|