Merge pull request #980 from rspec/remove_debugger

Remove debugger support.

Author: myronmarston

Changelog.md

@@ -16,6 +16,10 @@ Breaking Changes for 3.0.0:
   * `Spec::Runner.configure` rather than `RSpec.configure`.
   * `Rake::SpecTask` rather than `RSpec::Core::RakeTask`.
 * Remove deprecated support for `share_as` (Myron Marston).
+* Remove `--debug` option (and corresponding option on
+  `RSpec::Core::Configuration`). Instead, use `-r<debugger gem name>` to
+  load whichever debugger gem you wish to use (e.g. `ruby-debug`,
+  `debugger`, or `pry`) (Myron Marston).
 
 Enhancements
 

lib/rspec/core.rb

@@ -13,7 +13,6 @@
 require 'rbconfig'
 require_rspec['core/filter_manager']
 require_rspec['core/dsl']
-require_rspec['core/extensions/kernel']
 require_rspec['core/extensions/ordered']
 require_rspec['core/deprecation']
 require_rspec['core/reporter']

lib/rspec/core/configuration.rb

@@ -492,31 +492,6 @@ def requires=(paths)
         @requires += paths
       end
 
-      def debug=(bool)
-        return unless bool
-        begin
-          require 'ruby-debug'
-          Debugger.start
-        rescue LoadError => e
-          raise <<-EOM
-
-#{'*'*50}
-#{e.message}
-
-If you have it installed as a ruby gem, then you need to either require
-'rubygems' or configure the RUBYOPT environment variable with the value
-'rubygems'.
-
-#{e.backtrace.join("\n")}
-#{'*'*50}
-EOM
-        end
-      end
-
-      def debug?
-        !!defined?(Debugger)
-      end
-
       # Run examples defined on `line_numbers` in all files to run.
       def line_numbers=(line_numbers)
         filter_run :line_numbers => line_numbers.map{|l| l.to_i}

lib/rspec/core/configuration_options.rb

@@ -46,7 +46,7 @@ def filter_manager
     private
 
       NON_FORCED_OPTIONS = [
-        :debug, :requires, :libs, :profile, :drb, :files_or_directories_to_run,
+        :requires, :libs, :profile, :drb, :files_or_directories_to_run,
         :line_numbers, :full_description, :full_backtrace, :tty
       ].to_set
 

lib/rspec/core/extensions/kernel.rb

@@ -75,10 +75,6 @@ def parser(options)
           options[:order] = "rand:#{seed}"
         end
 
-        parser.on('-d', '--debugger', 'Enable debugging.') do |o|
-          options[:debug] = true
-        end
-
         parser.on('--fail-fast', 'Abort the run on first failure.') do |o|
           options[:fail_fast] = true
         end

lib/rspec/core/option_parser.rb

@@ -94,13 +94,6 @@
       end
     end
 
-    it "sets debug directly" do
-      opts = config_options_object("--debug")
-      config = RSpec::Core::Configuration.new
-      config.should_receive(:debug=).with(true)
-      opts.configure(config)
-    end
-
     it "merges --require specified by multiple configuration sources" do
       with_env_vars 'SPEC_OPTS' => "--require file_from_env" do
         opts = config_options_object(*%w[--require file_from_opts])
@@ -214,13 +207,6 @@
     end
   end
 
-  describe "--debug, -d" do
-    it "sets :debug => true" do
-      expect(parse_options("--debug")).to include(:debug => true)
-      expect(parse_options("-d")).to include(:debug => true)
-    end
-  end
-
   describe "--fail-fast" do
     it "defaults to false" do
       expect(parse_options[:fail_fast]).to be_false
@@ -251,38 +237,9 @@
   end
 
   describe "--drb, -X" do
-    context "combined with --debug" do
-      it "turns off the debugger if --drb is specified first" do
-        expect(config_options_object("--drb", "--debug").drb_argv).not_to include("--debug")
-        expect(config_options_object("--drb", "-d"     ).drb_argv).not_to include("--debug")
-        expect(config_options_object("-X",    "--debug").drb_argv).not_to include("--debug")
-        expect(config_options_object("-X",    "-d"     ).drb_argv).not_to include("--debug")
-      end
-
-      it "turns off the debugger option if --drb is specified later" do
-        expect(config_options_object("--debug", "--drb").drb_argv).not_to include("--debug")
-        expect(config_options_object("-d",      "--drb").drb_argv).not_to include("--debug")
-        expect(config_options_object("--debug", "-X"   ).drb_argv).not_to include("--debug")
-        expect(config_options_object("-d",      "-X"   ).drb_argv).not_to include("--debug")
-      end
-
-      it "turns off the debugger option if --drb is specified in the options file" do
-        File.open("./.rspec", "w") {|f| f << "--drb"}
-        expect(config_options_object("--debug").drb_argv).not_to include("--debug")
-        expect(config_options_object("-d"     ).drb_argv).not_to include("--debug")
-      end
-
-      it "turns off the debugger option if --debug is specified in the options file" do
-        File.open("./.rspec", "w") {|f| f << "--debug"}
-        expect(config_options_object("--drb").drb_argv).not_to include("--debug")
-        expect(config_options_object("-X"   ).drb_argv).not_to include("--debug")
-      end
-    end
-
     it "does not send --drb back to the parser after parsing options" do
       expect(config_options_object("--drb", "--color").drb_argv).not_to include("--drb")
     end
-
   end
 
   describe "--no-drb" do
@@ -344,11 +301,10 @@
       File.open("./.rspec", "w") {|f| f << "--line 37"}
       File.open("./.rspec-local", "w") {|f| f << "--format global"}
       File.open(File.expand_path("~/.rspec"), "w") {|f| f << "--color"}
-      with_env_vars 'SPEC_OPTS' => "--debug --example 'foo bar'" do
+      with_env_vars 'SPEC_OPTS' => "--example 'foo bar'" do
         options = parse_options("--drb")
         expect(options[:color]).to be_true
         expect(options[:line_numbers]).to eq(["37"])
-        expect(options[:debug]).to be_true
         expect(options[:full_description]).to eq([/foo\ bar/])
         expect(options[:drb]).to be_true
         expect(options[:formatters]).to eq([['global']])

spec/rspec/core/configuration_options_spec.rb

@@ -1070,55 +1070,6 @@ def metadata_hash(*args)
       end
     end
 
-    describe "#debug=true" do
-      before do
-        if defined?(Debugger)
-          @orig_debugger = Debugger
-          Object.send(:remove_const, :Debugger)
-        else
-          @orig_debugger = nil
-        end
-        config.stub(:require)
-        Object.const_set("Debugger", debugger)
-      end
-
-      after do
-        Object.send(:remove_const, :Debugger)
-        Object.const_set("Debugger", @orig_debugger) if @orig_debugger
-      end
-
-      let(:debugger) { double('Debugger').as_null_object }
-
-      it "requires 'ruby-debug'" do
-        config.should_receive(:require).with('ruby-debug')
-        config.debug = true
-      end
-
-      it "starts the debugger" do
-        debugger.should_receive(:start)
-        config.debug = true
-      end
-    end
-
-    describe "#debug=false" do
-      it "does not require 'ruby-debug'" do
-        config.should_not_receive(:require).with('ruby-debug')
-        config.debug = false
-      end
-    end
-
-    describe "#debug?" do
-      it 'returns true if the debugger has been loaded' do
-        stub_const("Debugger", Object.new)
-        expect(config.debug?).to be_true
-      end
-
-      it 'returns false if the debugger has not been loaded' do
-        hide_const("Debugger")
-        expect(config.debug?).to be_false
-      end
-    end
-
     describe "#output=" do
       it "sets the output" do
         output = double("output")