Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Commit 2116b29

Browse files
committed
Only simplecov newer versions
Simplecov has changed ruby version requirements for simplecov-html apparently. We could define the version of simplecov-html to install but there's no benefit to running coverage on every version so lets just install simplecov on newer versions like we do for rubocop
1 parent 3ab19e0 commit 2116b29

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

Gemfile

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,9 @@ platforms :jruby do
6363
end
6464
end
6565

66-
gem 'simplecov', '~> 0.8'
67-
68-
# No need to run rubocop on earlier versions
66+
# No need to run rubocop & simplecov on earlier versions
6967
if RUBY_VERSION >= '2.4' && RUBY_ENGINE == 'ruby'
68+
gem 'simplecov', '~> 0.8'
7069
gem "rubocop", "~> 0.52.1"
7170
end
7271

script/rspec_with_simplecov

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ begin
2424
# Simplecov emits some ruby warnings when loaded, so silence them.
2525
old_verbose, $VERBOSE = $VERBOSE, false
2626

27-
unless ENV['NO_COVERAGE'] || RUBY_VERSION.to_f < 2.1
27+
unless ENV['NO_COVERAGE'] || RUBY_VERSION.to_f < 2.4
2828
require 'simplecov'
2929

3030
SimpleCov.start do

0 commit comments

Comments
 (0)