Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Commit 25821d9

Browse files
committed
Refactor: configure_existing_groups -> on_existing_matching_groups
The latter is more generically useful.
1 parent 474e3b0 commit 25821d9

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

lib/rspec/core/configuration.rb

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1161,7 +1161,7 @@ def exclusion_filter
11611161
def include(mod, *filters)
11621162
meta = Metadata.build_hash_from(filters, :warn_about_example_group_filtering)
11631163
@include_modules.append(mod, meta)
1164-
configure_existing_groups(mod, meta, :safe_include)
1164+
on_existing_matching_groups(meta) { |group| safe_include(mod, group) }
11651165
end
11661166

11671167
# Tells RSpec to extend example groups with `mod`. Methods defined in
@@ -1197,7 +1197,7 @@ def include(mod, *filters)
11971197
def extend(mod, *filters)
11981198
meta = Metadata.build_hash_from(filters, :warn_about_example_group_filtering)
11991199
@extend_modules.append(mod, meta)
1200-
configure_existing_groups(mod, meta, :safe_extend)
1200+
on_existing_matching_groups(meta) { |group| safe_extend(mod, group) }
12011201
end
12021202

12031203
if RSpec::Support::RubyFeatures.module_prepends_supported?
@@ -1236,7 +1236,7 @@ def extend(mod, *filters)
12361236
def prepend(mod, *filters)
12371237
meta = Metadata.build_hash_from(filters, :warn_about_example_group_filtering)
12381238
@prepend_modules.append(mod, meta)
1239-
configure_existing_groups(mod, meta, :safe_prepend)
1239+
on_existing_matching_groups(meta) { |group| safe_prepend(mod, group) }
12401240
end
12411241
end
12421242

@@ -1826,10 +1826,9 @@ def configure_group_with(group, module_list, application_method)
18261826
end
18271827
end
18281828

1829-
def configure_existing_groups(mod, meta, application_method)
1829+
def on_existing_matching_groups(meta)
18301830
world.all_example_groups.each do |group|
1831-
next unless meta.empty? || MetadataFilter.apply?(:any?, meta, group.metadata)
1832-
__send__(application_method, mod, group)
1831+
yield group if meta.empty? || MetadataFilter.apply?(:any?, meta, group.metadata)
18331832
end
18341833
end
18351834

0 commit comments

Comments
 (0)