Merge pull request #1365 from rspec/reorder-deprecation-summary

Reorder deprecation_summary to come before dump_summary

Author: soulcutter

lib/rspec/core/reporter.rb

@@ -96,8 +96,8 @@ def finish
         notify :start_dump,    Notifications::NullNotification
         notify :dump_pending,  Notifications::NullNotification
         notify :dump_failures, Notifications::NullNotification
-        notify :dump_summary, Notifications::SummaryNotification.new(@duration, @example_count, @failure_count, @pending_count)
         notify :deprecation_summary, Notifications::NullNotification
+        notify :dump_summary, Notifications::SummaryNotification.new(@duration, @example_count, @failure_count, @pending_count)
         notify :seed, Notifications::SeedNotification.new(@configuration.seed, seed_used?)
       ensure
         notify :close, Notifications::NullNotification

spec/rspec/core/reporter_spec.rb

@@ -20,6 +20,16 @@ module RSpec::Core
           expect { reporter.finish }.to_not raise_error
         end
       end
+
+      it "dumps the failure summary after the deprecation summary so failures don't scroll off the screen and get missed" do
+        formatter = instance_double("RSpec::Core::Formatter::ProgressFormatter")
+        reporter.register_listener(formatter, :dump_summary, :deprecation_summary)
+
+        expect(formatter).to receive(:deprecation_summary).ordered
+        expect(formatter).to receive(:dump_summary).ordered
+
+        reporter.finish
+      end
     end
 
     context "given one formatter" do