fix most of the offences that will not change the current style

Author: bennacer860

.rubocop.yml

@@ -13,6 +13,13 @@ ClassLength:
 LineLength:
   Max: 130
 
+# This should go down over time
+Metrics/AbcSize:
+  Max: 40
+
+Metrics/PerceivedComplexity:
+  Max: 15
+
 Lint/HandleExceptions:
   Exclude:
     - lib/rspec/core/example.rb
@@ -27,6 +34,13 @@ Lint/LiteralInInterpolation:
 MethodLength:
   Max: 40
 
+Style/AccessModifierIndentation:
+  Enabled: false
+
+# This could change depending of the style used
+Style/MultilineOperationIndentation:
+  Enabled: false
+
 # Exclude the default spec_helper to make it easier to uncomment out
 # default settings (for both users and the Cucumber suite).
 Style/BlockComments:

lib/rspec/core/bisect/runner.rb

@@ -25,7 +25,7 @@ def command_for(locations)
           parts << RUBY << load_path
           parts << open3_safe_escape(RSpec::Core.path_to_executable)
 
-          parts << "--format"   << "bisect"
+          parts << "--format" << "bisect"
           parts << "--drb-port" << @server.drb_port
           parts.concat reusable_cli_options
           parts.concat locations.map { |l| open3_safe_escape(l) }
@@ -131,8 +131,7 @@ def load_path
         # https://github.com/ruby/rake/commit/968682759b3b65e42748cd2befb2ff3e982272d9
         RUBY = File.join(
           RbConfig::CONFIG['bindir'],
-          RbConfig::CONFIG['ruby_install_name'] + RbConfig::CONFIG['EXEEXT']).
-          sub(/.*\s.*/m, '"\&"')
+          RbConfig::CONFIG['ruby_install_name'] + RbConfig::CONFIG['EXEEXT']).sub(/.*\s.*/m, '"\&"')
       end
     end
   end

lib/rspec/core/configuration.rb

@@ -580,7 +580,7 @@ def mock_with(framework)
           end
 
         new_name, old_name = [framework_module, @mock_framework].map do |mod|
-          mod.respond_to?(:framework_name) ?  mod.framework_name : :unnamed
+          mod.respond_to?(:framework_name) ? mod.framework_name : :unnamed
         end
 
         unless new_name == old_name
@@ -1686,7 +1686,7 @@ def get_matching_files(path, pattern)
 
       def file_glob_from(path, pattern)
         stripped = "{#{pattern.gsub(/\s*,\s*/, ',')}}"
-        return stripped if pattern =~ /^(\.\/)?#{Regexp.escape path}/ || absolute_pattern?(pattern)
+        return stripped if pattern =~ %r{^(\.\/)?#{Regexp.escape path}} || absolute_pattern?(pattern)
         File.join(path, stripped)
       end
 
@@ -1712,7 +1712,8 @@ def extract_location(path)
 
         if match
           captures = match.captures
-          path, lines = captures[0], captures[1][1..-1].split(":").map { |n| n.to_i }
+          path = captures[0]
+          lines =  captures[1][1..-1].split(":").map(&:id)
           filter_manager.add_location path, lines
         else
           path, scoped_ids = Example.parse_id(path)

lib/rspec/core/configuration_options.rb

@@ -64,7 +64,7 @@ def force?(key)
       end
 
       def order(keys)
-        OPTIONS_ORDER.reverse.each do |key|
+        OPTIONS_ORDER.reverse_each do |key|
           keys.unshift(key) if keys.delete(key)
         end
         keys

lib/rspec/core/filter_manager.rb

@@ -107,7 +107,7 @@ def file_scoped_include?(ex_metadata, ids, locations)
         return yield if no_location_filters && no_id_filters
 
         MetadataFilter.filter_applies?(:ids, ids, ex_metadata) ||
-        MetadataFilter.filter_applies?(:locations, locations, ex_metadata)
+          MetadataFilter.filter_applies?(:locations, locations, ex_metadata)
       end
     end
 

lib/rspec/core/formatters.rb

@@ -168,9 +168,9 @@ def add(formatter_to_use, *paths)
 
     def find_formatter(formatter_to_use)
       built_in_formatter(formatter_to_use) ||
-      custom_formatter(formatter_to_use)   ||
-      (raise ArgumentError, "Formatter '#{formatter_to_use}' unknown - " \
-                            "maybe you meant 'documentation' or 'progress'?.")
+        custom_formatter(formatter_to_use) ||
+        (raise ArgumentError, "Formatter '#{formatter_to_use}' unknown - " \
+            "maybe you meant 'documentation' or 'progress'?.")
     end
 
     def register(formatter, notifications)

lib/rspec/core/formatters/deprecation_formatter.rb

@@ -85,7 +85,7 @@ def output_formatted(str)
           end
 
           def deprecation_type_for(data)
-            data.message.gsub(/(\w+\/)+\w+\.rb:\d+/, '')
+            data.message.gsub(%r{(\w+\/)+\w+\.rb:\d+}, '')
           end
         end
 

lib/rspec/core/formatters/profile_formatter.rb

@@ -37,7 +37,7 @@ def dump_profile_slowest_examples(profile)
           profile.slowest_examples.each do |example|
             @output.puts "  #{example.full_description}"
             @output.puts "    #{bold(Helpers.format_seconds(example.execution_result.run_time))} " \
-                         "#{bold("seconds")} #{format_caller(example.location)}"
+                         "#{bold('seconds')} #{format_caller(example.location)}"
           end
         end
 
@@ -46,7 +46,7 @@ def dump_profile_slowest_example_groups(profile)
 
           @output.puts "\nTop #{profile.slowest_groups.size} slowest example groups:"
           profile.slowest_groups.each do |loc, hash|
-            average = "#{bold(Helpers.format_seconds(hash[:average]))} #{bold("seconds")} average"
+            average = "#{bold(Helpers.format_seconds(hash[:average]))} #{bold('seconds')} average"
             total   = "#{Helpers.format_seconds(hash[:total_time])} seconds"
             count   = Helpers.pluralize(hash[:count], "example")
             @output.puts "  #{hash[:description]}"

lib/rspec/core/formatters/snippet_extractor.rb

@@ -9,7 +9,7 @@ class SnippetExtractor
         # @private
         module NullConverter
           def self.convert(code)
-            %Q(#{code}\n<span class="comment"># Install the coderay gem to get syntax highlighting</span>)
+            %(#{code}\n<span class="comment"># Install the coderay gem to get syntax highlighting</span>)
           end
         end
 

lib/rspec/core/hooks.rb

@@ -585,8 +585,8 @@ def extract_scope_from(args)
             normalized_scope_for(args.shift)
           elsif args.any? { |a| a.is_a?(Symbol) }
             error_message = "You must explicitly give a scope " \
-              "(#{SCOPES.join(", ")}) or scope alias " \
-              "(#{SCOPE_ALIASES.keys.join(", ")}) when using symbols as " \
+              "(#{SCOPES.join(', ')}) or scope alias " \
+              "(#{SCOPE_ALIASES.keys.join(', ')}) when using symbols as " \
               "metadata for a hook."
             raise ArgumentError.new error_message
           else

lib/rspec/core/metadata.rb

@@ -151,7 +151,7 @@ def populate_location_attributes
           metadata[:line_number]        = line_number.to_i
           metadata[:location]           = "#{relative_file_path}:#{line_number}"
           metadata[:absolute_file_path] = File.expand_path(relative_file_path)
-          metadata[:rerun_file_path]  ||= relative_file_path
+          metadata[:rerun_file_path]    ||= relative_file_path
           metadata[:scoped_id]          = build_scoped_id_for(relative_file_path)
         end
 
@@ -185,7 +185,7 @@ def ensure_valid_user_keys
           RESERVED_KEYS.each do |key|
             next unless user_metadata.key?(key)
             raise <<-EOM.gsub(/^\s+\|/, '')
-              |#{"*" * 50}
+              |#{'*' * 51}
               |:#{key} is not allowed
               |
               |RSpec reserves some hash keys for its own internal use,
@@ -196,7 +196,7 @@ def ensure_valid_user_keys
               |Here are all of RSpec's reserved hash keys:
               |
               |  #{RESERVED_KEYS.join("\n  ")}
-              |#{"*" * 50}
+              |#{'*' * 50}
             EOM
           end
         end

lib/rspec/core/notifications.rb

@@ -10,6 +10,7 @@ module Notifications
     # @private
     module NullColorizer
       module_function
+
       def wrap(line, _code_or_symbol)
         line
       end
@@ -338,10 +339,10 @@ def colorized_totals_line(colorizer=::RSpec::Core::Formatters::ConsoleCodes)
       # @return [String] A colorized summary line.
       def colorized_rerun_commands(colorizer=::RSpec::Core::Formatters::ConsoleCodes)
         "\nFailed examples:\n\n" +
-        failed_examples.map do |example|
-          colorizer.wrap("rspec #{rerun_argument_for(example)}", RSpec.configuration.failure_color) + " " +
-          colorizer.wrap("# #{example.full_description}",   RSpec.configuration.detail_color)
-        end.join("\n")
+          failed_examples.map do |example|
+            colorizer.wrap("rspec #{rerun_argument_for(example)}", RSpec.configuration.failure_color) + " " +
+              colorizer.wrap("# #{example.full_description}", RSpec.configuration.detail_color)
+          end.join("\n")
       end
 
       # @return [String] a formatted version of the time it took to run the

lib/rspec/core/option_parser.rb

@@ -251,7 +251,6 @@ def parser(options)
             raise OptionParser::InvalidOption.new
           end
         end
-
       end
     end
     # rubocop:enable MethodLength