Rename modification time to recently modified ordering

Author: MatheusRich

features/command_line/order.md

@@ -13,8 +13,9 @@ order of groups at each level is randomized.
 
 With `rand` you can also specify a seed.
 
-Use `modification_time` to run the most recently modified files first. You can
-combine it with `--next-failure` to find the most recent failing spec.
+Use `recently-modified` to run the most recently modified files first. You can
+combine it with `--only-failures` to find the most recent failing specs. Note
+that `recently-modified` and `rand` are mutually exclusives.
 
 ## Example usage
 
@@ -25,5 +26,5 @@ config file (e.g. `.rspec`) and you want to override it from the command line.
 --order rand
 --order rand:123
 --seed 123 # same as --order rand:123
---modification_time
+--order recently-modified
 </code></pre>

lib/rspec/core/option_parser.rb

@@ -62,7 +62,7 @@ def parser(options)
                   '  [rand]              randomize the order of groups and examples',
                   '  [random]            alias for rand',
                   '  [random:SEED]       e.g. --order random:123',
-                  '  [modification_time] run the most recently modified files first') do |o|
+                  '  [recently-modified] run the most recently modified files first') do |o|
           options[:order] = o
         end
 

lib/rspec/core/ordering.rb

@@ -60,7 +60,7 @@ def jenkins_hash_digest(string)
 
       # @private
       # Orders items by modification time (most recent modified first).
-      class ModificationTime
+      class RecentlyModified
         def order(list)
           list.sort_by { |item| -File.mtime(item.metadata[:absolute_file_path]).to_i }
         end
@@ -86,7 +86,7 @@ def initialize(configuration)
           @strategies    = {}
 
           register(:random, Random.new(configuration))
-          register(:modification_time, ModificationTime.new)
+          register(:recently_modified, RecentlyModified.new)
 
           identity = Identity.new
           register(:defined, identity)
@@ -141,8 +141,8 @@ def order=(type)
                             :random
                           elsif order == 'defined'
                             :defined
-                          elsif order == 'modification_time'
-                            :modification_time
+                          elsif order == 'recently-modified'
+                            :recently_modified
                           end
 
           register_ordering(:global, ordering_registry.fetch(ordering_name)) if ordering_name

spec/rspec/core/ordering_spec.rb

@@ -81,7 +81,7 @@ def order_with(seed)
         end
       end
 
-      RSpec.describe ModificationTime do
+      RSpec.describe RecentlyModified do
         before do
           allow(File).to receive(:mtime).with('./file_1.rb').and_return(::Time.new)
           allow(File).to receive(:mtime).with('./file_2.rb').and_return(::Time.new + 1)
@@ -90,7 +90,7 @@ def order_with(seed)
         it 'orders list by file modification time' do
           file_1 = instance_double(Example, :metadata => { :absolute_file_path => './file_1.rb' })
           file_2 = instance_double(Example, :metadata => { :absolute_file_path => './file_2.rb' })
-          strategy = ModificationTime.new
+          strategy = RecentlyModified.new
 
           expect(strategy.order([file_1, file_2])).to eq([file_2, file_1])
         end