Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Commit 52b0b18

Browse files
committed
Make wording more accurate.
The existing wording was confusing for this situation: * You have two specs, a and b. * Spec a always fails. * Spec b fails only if a runs first. In such a situation, your failures are order dependent, but our bisector printed "failure is not order dependent", which was quite confusing. The new wording, "failures(s) do not require any non-failures to run first" is more accurate.
1 parent de8d283 commit 52b0b18

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

lib/rspec/core/formatters/bisect_progress_formatter.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ def bisect_dependency_check_passed(_notification)
3939
end
4040

4141
def bisect_dependency_check_failed(_notification)
42-
output.puts " failure is not order-dependent"
42+
output.puts " failure(s) do not require any non-failures to run first"
4343
end
4444

4545
def bisect_round_started(notification, include_trailing_space=true)

spec/rspec/core/bisect/coordinator_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ def find_minimal_repro(output, formatter=Formatters::BisectProgressFormatter)
108108
|Bisect started using options: ""
109109
|Running suite to find failures... (n.nnnn seconds)
110110
|Starting bisect with 1 failing example and 7 non-failing examples.
111-
|Checking that failure(s) are order-dependent... failure is not order-dependent
111+
|Checking that failure(s) are order-dependent... failure(s) do not require any non-failures to run first
112112
|
113113
|Bisect complete! Reduced necessary non-failing examples from 7 to 0 in n.nnnn seconds.
114114
|

0 commit comments

Comments
 (0)