Merge pull request #2102 from bootstraponline/memory_leak

Don't reset before_context_ivars in reset_memoized

Author: JonRowe

lib/rspec/core/example_group.rb

@@ -348,7 +348,6 @@ def self.reset_memoized
         @_descendants = nil
         @parent_groups = nil
         @declaration_line_numbers = nil
-        @before_context_ivars = nil
       end
 
       # Adds an example to the example group

lib/rspec/core/rake_task.rb

@@ -4,9 +4,11 @@
 
 RSpec::Support.require_rspec_support "ruby_features"
 
+# :nocov:
 unless RSpec::Support.respond_to?(:require_rspec_core)
   RSpec::Support.define_optimized_require_for_rspec(:core) { |f| require_relative "../#{f}" }
 end
+# :nocov:
 
 RSpec::Support.require_rspec_core "shell_escape"
 

spec/rspec/core/example_group_spec.rb

@@ -1796,9 +1796,7 @@ def group_ids group
 
       group.add_example group.examples.first
       expect(group.examples.length).to eq(2)
-
-      new_ids = group_ids group
-      new_ids.each_with_index { |id, idx| expect(id).to_not eq(original_ids[idx]) }
+      expect(original_ids).to_not eq(group_ids(group))
     end
 
     it 'allows removing examples' do
@@ -1813,9 +1811,7 @@ def group_ids group
 
       group.remove_example group.examples.first
       expect(group.examples.length).to eq(0)
-
-      new_ids = group_ids group
-      new_ids.each_with_index { |id, idx| expect(id).to_not eq(original_ids[idx]) }
+      expect(original_ids).to_not eq(group_ids(group))
     end
   end
 end