Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Commit 685117c

Browse files
committed
Adjust method names
`define_aliases` actually only defined one. `define_predicate_for` was always passed a single argument.
1 parent 0e2a20d commit 685117c

File tree

1 file changed

+10
-12
lines changed

1 file changed

+10
-12
lines changed

lib/rspec/core/configuration.rb

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -67,21 +67,19 @@ def self.define_reader(name)
6767
end
6868

6969
# @private
70-
def self.define_aliases(name, alias_name)
70+
def self.define_alias(name, alias_name)
7171
alias_method alias_name, name
7272
alias_method "#{alias_name}=", "#{name}="
73-
define_predicate_for alias_name
73+
define_predicate alias_name
7474
end
7575

7676
# @private
77-
def self.define_predicate_for(*names)
78-
names.each do |name|
79-
class_eval <<-PREDICATE, __FILE__ , __LINE__ + 1
80-
def #{name}?
81-
!!#{name}
82-
end
83-
PREDICATE
84-
end
77+
def self.define_predicate(name)
78+
class_eval <<-PREDICATE, __FILE__ , __LINE__ + 1
79+
def #{name}?
80+
!!#{name}
81+
end
82+
PREDICATE
8583
end
8684

8785
# @private
@@ -94,7 +92,7 @@ def self.add_setting(name, opts={})
9492
add_read_only_setting name
9593

9694
Array(opts[:alias_with]).each do |alias_name|
97-
define_aliases(name, alias_name)
95+
define_alias(name, alias_name)
9896
end
9997
end
10098

@@ -104,7 +102,7 @@ def self.add_setting(name, opts={})
104102
def self.add_read_only_setting(name, opts={})
105103
raise "Use the instance add_setting method if you want to set a default" if opts.key?(:default)
106104
define_reader name
107-
define_predicate_for name
105+
define_predicate name
108106
end
109107

110108
# @macro [attach] add_setting

0 commit comments

Comments
 (0)