Add fail_if_no_examples option: support custom failure_exit_code

and correct cucumber test to be better rendered on relish

Author: xmik

features/configuration/fail_if_no_examples.feature

@@ -1,15 +1,8 @@
 Feature: fail if no examples
 
-  Use the `fail_if_no_examples` option to make RSpec exit with exit status 1
-  if there are 0 examples. Using this option, it is recommended to add:
-  a `--require spec_helper` option to `.rspec` file to ensure the `fail_if_no_examples`
-  option is set even if no spec files are loaded.
+  Use the `fail_if_no_examples` option to make RSpec exit with a failure status (by default 1) if there are 0 examples. Using this option, it is recommended to add a `--require spec_helper` option to `.rspec` file to ensure the `fail_if_no_examples` option is set even if no spec files are loaded.
 
-  This option may be particularly useful when you happen to not run RSpec tests
-  locally, but rely on CI to do this. This prevents from false positive builds,
-  when you expected some RSpec examples to be run, but none were run. Such
-   a situation may be caused by your misconfiguration or regression/major changes
-  in RSpec.
+  This option may be particularly useful when you happen to not run RSpec tests locally, but rely on CI to do this. This prevents from false positive builds, when you expected some RSpec examples to be run, but none were run. Such a situation may be caused by your misconfiguration or regression/major changes in RSpec.
 
   Background:
     Given a file named "spec/spec_helper.rb" with:
@@ -29,18 +22,10 @@ Feature: fail if no examples
       end
       """
 
-  Scenario: Examples file has invalid name, thus there are no examples run
+  Scenario: Examples file name is not matched by RSpec pattern, thus there are no examples run
     When I run `rspec`
     Then it should fail with "0 examples, 0 failures"
 
-  Scenario: Examples file has valid name and 1 example is run
-    Given a file named "spec/some_spec.rb" with:
-      """ruby
-      RSpec.describe 'something' do
-        it 'succeeds' do
-          true
-        end
-      end
-      """
-    When I run `rspec --pattern spec/**/*_spec.rb`
+  Scenario: Examples file name is matched by RSpec pattern, 1 example is run
+    When I run `rspec --pattern spec/**/*.spec.rb`
     Then it should pass with "1 example, 0 failures"

lib/rspec/core/runner.rb

@@ -112,7 +112,7 @@ def run_specs(example_groups)
         @configuration.reporter.report(examples_count) do |reporter|
           @configuration.with_suite_hooks do
             if examples_count == 0 && @configuration.fail_if_no_examples
-              return 1
+              return @configuration.failure_exit_code
             end
             example_groups.map { |g| g.run(reporter) }.all? ? 0 : @configuration.failure_exit_code
           end

spec/integration/fail_if_no_examples_spec.rb

@@ -21,14 +21,14 @@ def passing_example(fail_if_no_examples)
       write_file 'spec/example_spec.rb', passing_example(true)
       run_command ""
       expect(last_cmd_stdout).to include("1 example, 0 failures")
-      expect(last_cmd_exitstatus).to eq(0)
+      expect(last_cmd_exit_status).to eq(0)
     end
 
     it 'succeeds if fail_if_no_examples set to false' do
       write_file 'spec/example_spec.rb', passing_example(false)
       run_command ""
       expect(last_cmd_stdout).to include("1 example, 0 failures")
-      expect(last_cmd_exitstatus).to eq(0)
+      expect(last_cmd_exit_status).to eq(0)
     end
   end
 
@@ -49,14 +49,14 @@ def failing_example(fail_if_no_examples)
       write_file 'spec/example_spec.rb', failing_example(true)
       run_command ""
       expect(last_cmd_stdout).to include("1 example, 1 failure")
-      expect(last_cmd_exitstatus).to eq(1)
+      expect(last_cmd_exit_status).to eq(1)
     end
 
     it 'fails if fail_if_no_examples set to false' do
       write_file 'spec/example_spec.rb', failing_example(false)
       run_command ""
       expect(last_cmd_stdout).to include("1 example, 1 failure")
-      expect(last_cmd_exitstatus).to eq(1)
+      expect(last_cmd_exit_status).to eq(1)
     end
   end
 
@@ -74,14 +74,35 @@ def no_examples(fail_if_no_examples)
       write_file 'spec/example_spec.rb', no_examples(true)
       run_command ""
       expect(last_cmd_stdout).to include("0 examples, 0 failures")
-      expect(last_cmd_exitstatus).to eq(1)
+      expect(last_cmd_exit_status).to eq(1)
     end
 
     it 'succeeds if fail_if_no_examples set to false' do
       write_file 'spec/example_spec.rb', no_examples(false)
       run_command ""
       expect(last_cmd_stdout).to include("0 examples, 0 failures")
-      expect(last_cmd_exitstatus).to eq(0)
+      expect(last_cmd_exit_status).to eq(0)
+    end
+
+    context 'when custom failure_exit_code set' do
+      def no_examples_custom_failure_exit_code(fail_if_no_examples)
+        "
+          RSpec.configure do |c|
+            c.fail_if_no_examples = #{fail_if_no_examples}
+            c.failure_exit_code = 15
+          end
+
+          RSpec.describe 'something' do
+          end
+        "
+      end
+
+      it 'fails if fail_if_no_examples set to true' do
+        write_file 'spec/example_spec.rb', no_examples_custom_failure_exit_code(true)
+        run_command ""
+        expect(last_cmd_stdout).to include("0 examples, 0 failures")
+        expect(last_cmd_exit_status).to eq(15)
+      end
     end
   end
 end

spec/support/aruba_support.rb

@@ -10,7 +10,7 @@ module ArubaLoader
   let(:stderr) { StringIO.new }
   let(:stdout) { StringIO.new }
 
-  attr_reader :last_cmd_stdout, :last_cmd_stderr, :last_cmd_exitstatus
+  attr_reader :last_cmd_stdout, :last_cmd_stderr, :last_cmd_exit_status
 
   def run_command(cmd)
     RSpec.configuration.color = true
@@ -24,7 +24,7 @@ def run_command(cmd)
 
     handle_current_dir_change do
       in_current_dir do
-        @last_cmd_exitstatus = RSpec::Core::Runner.run(cmd_parts, temp_stderr, temp_stdout)
+        @last_cmd_exit_status = RSpec::Core::Runner.run(cmd_parts, temp_stderr, temp_stdout)
       end
     end
   ensure