Clearer terminology in run-counting specs

Author: urbanautomaton

spec/rspec/core/bisect/example_minimizer_spec.rb

@@ -50,21 +50,24 @@ module RSpec::Core
       )
     end
 
-    context 'with an unminimisable run' do
-      class RoundCountingReporter < RSpec::Core::NullReporter
+    context 'with an unminimisable failure' do
+      class RunCountingReporter < RSpec::Core::NullReporter
         attr_accessor :round_count
+        attr_accessor :example_count
+        def initialize
+          @round_count = 0
+        end
 
-        def publish(event, *_args)
-          public_send(event) if respond_to? event
+        def publish(event, *args)
+          public_send(event, *args) if respond_to? event
         end
 
-        def bisect_individual_run_start
-          self.round_count ||= 0
+        def bisect_individual_run_start(_notification)
           self.round_count += 1
         end
       end
 
-      let(:counting_reporter) { RoundCountingReporter.new }
+      let(:counting_reporter) { RunCountingReporter.new }
       let(:fake_runner) do
         FakeBisectRunner.new(
           %w[ ex_1 ex_2 ex_3 ex_4 ex_5 ex_6 ex_7 ex_8 ex_9 ],
@@ -74,15 +77,15 @@ def bisect_individual_run_start
       end
       let(:minimizer) { Bisect::ExampleMinimizer.new(fake_runner, counting_reporter) }
 
-      it 'returns the full command if the run can not be reduced' do
+      it 'returns the full command if the failure can not be reduced' do
         minimizer.find_minimal_repro
 
         expect(minimizer.repro_command_for_currently_needed_ids).to eq(
           "rspec ex_1 ex_2 ex_3 ex_4 ex_5 ex_6 ex_7 ex_8 ex_9"
         )
       end
 
-      it 'detects an unminimisable run in the minimum number of rounds' do
+      it 'detects an unminimisable failure in the minimum number of runs' do
         minimizer.find_minimal_repro
 
         expect(counting_reporter.round_count).to eq(15)