Refactor: create factory method for bisect failed error.

Also, move it to `utilities` as the server will not always be loaded.

Author: myronmarston

lib/rspec/core/bisect/coordinator.rb

@@ -1,6 +1,7 @@
 RSpec::Support.require_rspec_core "bisect/shell_command"
 RSpec::Support.require_rspec_core "bisect/shell_runner"
 RSpec::Support.require_rspec_core "bisect/example_minimizer"
+RSpec::Support.require_rspec_core "bisect/utilities"
 RSpec::Support.require_rspec_core "formatters/bisect_progress_formatter"
 
 module RSpec

lib/rspec/core/bisect/example_minimizer.rb

@@ -1,3 +1,5 @@
+RSpec::Support.require_rspec_core "bisect/utilities"
+
 module RSpec
   module Core
     module Bisect

lib/rspec/core/bisect/server.rb

@@ -6,9 +6,6 @@ module RSpec
   module Core
     # @private
     module Bisect
-      # @private
-      BisectFailedError = Class.new(StandardError)
-
       # @private
       # A DRb server that receives run results from a separate RSpec process
       # started by the bisect process.
@@ -28,7 +25,7 @@ def capture_run_results(files_or_directories_to_run=[], expected_failures=[])
           run_output = yield
 
           if latest_run_results.nil? || latest_run_results.all_example_ids.empty?
-            raise_bisect_failed(run_output)
+            raise BisectFailedError.for_failed_spec_run(run_output)
           end
 
           latest_run_results
@@ -58,13 +55,6 @@ def drb_port
 
         # Fetched via DRb to tell clients which files to run
         attr_accessor :files_or_directories_to_run
-
-      private
-
-        def raise_bisect_failed(run_output)
-          raise BisectFailedError, "Failed to get results from the spec " \
-                "run. Spec run output:\n\n#{run_output}"
-        end
       end
     end
   end

lib/rspec/core/bisect/utilities.rb

@@ -3,6 +3,14 @@ module Core
     module Bisect
       # @private
       ExampleSetDescriptor = Struct.new(:all_example_ids, :failed_example_ids)
+
+      # @private
+      class BisectFailedError < StandardError
+        def self.for_failed_spec_run(spec_output)
+          new("Failed to get results from the spec run. Spec run output:\n\n" +
+              spec_output)
+        end
+      end
     end
   end
 end