prevent formater loader registering duplicate listeners

Author: JonRowe

Changelog.md

@@ -70,6 +70,8 @@ Bug Fixes:
   where filtered to a particular location.  (Ben Axnick, #1963)
 * Fix time formatting logic so that it displays 70 seconds as "1 minute,
   10 seconds" rather than "1 minute, 1 second". (Paul Brennan, #1984)
+* Fix regression where the formatter loader would allow duplicate formatters.
+  (Jon Rowe, #1990)
 
 ### 3.2.3 / 2015-04-06
 [Full Changelog](http://github.com/rspec/rspec-core/compare/v3.2.2...v3.2.3)

lib/rspec/core/formatters.rb

@@ -143,9 +143,11 @@ def add(formatter_to_use, *paths)
 
       if !Loader.formatters[formatter_class].nil?
         formatter = formatter_class.new(*args)
+        return formatter if duplicate_formatter_exists?(formatter)
         @reporter.register_listener formatter, *notifications_for(formatter_class)
       elsif defined?(RSpec::LegacyFormatters)
         formatter = RSpec::LegacyFormatters.load_formatter formatter_class, *args
+        return formatter if duplicate_formatter_exists?(formatter)
         @reporter.register_listener formatter, *formatter.notifications
       else
         call_site = "Formatter added at: #{::RSpec::CallerFilter.first_non_rspec_line}"
@@ -163,7 +165,7 @@ def add(formatter_to_use, *paths)
         WARNING
         return
       end
-      @formatters << formatter unless duplicate_formatter_exists?(formatter)
+      @formatters << formatter
       formatter
     end
 

spec/rspec/core/formatters_spec.rb

@@ -117,6 +117,7 @@ module RSpec::Core::Formatters
         before { loader.add :documentation, output }
 
         it "doesn't add the formatter for the same output target" do
+          expect(reporter).to_not receive(:register_listener)
           expect {
             loader.add :documentation, output
           }.not_to change { loader.formatters.length }