Run expectation outside of $SAFE 1+ environment

... because the matcher may be autoloaded if it's used first time in the
process and raises SecurityError.

Author: yujinakayama

spec/rspec/core/formatters/exception_presenter_spec.rb

@@ -464,9 +464,9 @@ def read_failed_lines
         let(:exception) { instance_double(Exception, :backtrace => [ "#{__FILE__}:#{__LINE__}"]) }
 
         it "is handled gracefully" do
-          with_safe_set_to_level_that_triggers_security_errors do
-            expect { read_failed_lines }.not_to raise_error
-          end
+          expect {
+            with_safe_set_to_level_that_triggers_security_errors { read_failed_lines }
+          }.not_to raise_error
         end
       end
 

spec/rspec/core/metadata_spec.rb

@@ -17,11 +17,13 @@ module Core
         it "gracefully returns nil if run in a secure thread" do
           # Ensure our call to `File.expand_path` is not cached as that is the insecure operation.
           Metadata.instance_eval { @relative_path_regex = nil }
-          with_safe_set_to_level_that_triggers_security_errors do
-            value = Metadata.relative_path(".")
-            # on some rubies, File.expand_path is not a security error, so accept "." as well
-            expect([nil, "."]).to include(value)
+
+          value = with_safe_set_to_level_that_triggers_security_errors do
+            Metadata.relative_path(".")
           end
+
+          # on some rubies, File.expand_path is not a security error, so accept "." as well
+          expect([nil, "."]).to include(value)
         end
 
         it 'should not transform directories beginning with the same prefix' do