fixup! Use isolated_home helper

Author: pirj

.rspec

@@ -1,4 +1,3 @@
 --order rand
 --warnings
 --require spec_helper
---no-profile

spec/integration/spec_file_load_errors_spec.rb

@@ -83,8 +83,7 @@
     EOS
   end
 
-  it 'nicely handles load-time errors in user spec files' do
-    write_file ".rspec", "--no-profile"
+  it 'nicely handles load-time errors in user spec files', isolated_home: true do
     write_file_formatted "1_spec.rb", "
       boom
 

spec/integration/suite_hooks_errors_spec.rb

@@ -32,7 +32,6 @@
   end
 
   def run_spec_expecting_non_zero(before_or_after)
-    write_file ".rspec", "--no-profile"
     write_file "the_spec.rb", "
       RSpec.configure do |c|
         c.#{before_or_after}(:suite) do
@@ -50,7 +49,7 @@ def run_spec_expecting_non_zero(before_or_after)
     normalize_durations(last_cmd_stdout)
   end
 
-  it 'nicely formats errors in `before(:suite)` hooks and exits with non-zero' do
+  it 'nicely formats errors in `before(:suite)` hooks and exits with non-zero', isolated_home: true do
     output = run_spec_expecting_non_zero(:before)
     expect(output).to eq unindent(<<-EOS)
 
@@ -68,7 +67,7 @@ def run_spec_expecting_non_zero(before_or_after)
     EOS
   end
 
-  it 'nicely formats errors in `after(:suite)` hooks and exits with non-zero' do
+  it 'nicely formats errors in `after(:suite)` hooks and exits with non-zero', isolated_home: true do
     output = run_spec_expecting_non_zero(:after)
     expect(output).to eq unindent(<<-EOS)
       .
@@ -86,8 +85,7 @@ def run_spec_expecting_non_zero(before_or_after)
     EOS
   end
 
-  it 'nicely formats errors from multiple :suite hooks of both types and exits with non-zero' do
-    write_file ".rspec", "--no-profile"
+  it 'nicely formats errors from multiple :suite hooks of both types and exits with non-zero', isolated_home: true do
     write_file "the_spec.rb", "
       RSpec.configure do |c|
         c.before(:suite) { raise 'before 1' }

spec/rspec/core/formatters/documentation_formatter_spec.rb

@@ -100,7 +100,7 @@ def execution_result(values)
     end
 
     # The backtrace is slightly different on JRuby/Rubinius so we skip there.
-    it 'produces the expected full output', :if => RSpec::Support::Ruby.mri? do
+    it 'produces the expected full output', isolated_home: true, :if => RSpec::Support::Ruby.mri? do
       output = run_example_specs_with_formatter("doc")
       output.gsub!(/ +$/, '') # strip trailing whitespace
 

spec/rspec/core/formatters/html_formatter_spec.rb

@@ -57,8 +57,8 @@ def extract_backtrace_from(doc)
           end
         end
 
-        describe 'produced HTML', :slow, :if => RUBY_VERSION >= '2.0.0' do
-          it "is identical to the one we designed manually", :pending => (defined?(RUBY_ENGINE) && RUBY_ENGINE == 'jruby') do
+        describe 'produced HTML', :slow, isolated_home: true, :if => RUBY_VERSION >= '2.0.0' do
+          it 'is identical to the one we designed manually', :pending => (defined?(RUBY_ENGINE) && RUBY_ENGINE == 'jruby') do
             expect(actual_html).to eq(expected_html)
           end
 

spec/rspec/core/formatters/progress_formatter_spec.rb

@@ -40,7 +40,7 @@
   end
 
   # The backtrace is slightly different on JRuby/Rubinius so we skip there.
-  it 'produces the expected full output', :if => RSpec::Support::Ruby.mri? do
+  it 'produces the expected full output', isolated_home: true, :if => RSpec::Support::Ruby.mri? do
     output = run_example_specs_with_formatter("progress")
     output.gsub!(/ +$/, '') # strip trailing whitespace
 

spec/support/formatter_support.rb

@@ -69,6 +69,12 @@ def expected_summary_output_for_example_specs
         |     # ./spec/rspec/core/resources/formatter_specs.rb:18
         |     # ./spec/support/formatter_support.rb:41:in `run_rspec_with_formatter'
         |     # ./spec/support/formatter_support.rb:3:in `run_example_specs_with_formatter'
+        |     # ./spec/support/isolated_home_directory.rb:13:in `block (5 levels) in <top (required)>'
+        |     # ./spec/spec_helper.rb:46:in `with_env_vars'
+        |     # ./spec/support/isolated_home_directory.rb:12:in `block (4 levels) in <top (required)>'
+        |     # ./spec/spec_helper.rb:57:in `without_env_vars'
+        |     # ./spec/support/isolated_home_directory.rb:11:in `block (3 levels) in <top (required)>'
+        |     # ./spec/support/isolated_home_directory.rb:7:in `block (2 levels) in <top (required)>'
         |     # ./spec/support/sandboxing.rb:16
         |     # ./spec/support/sandboxing.rb:7
         |
@@ -89,6 +95,12 @@ def expected_summary_output_for_example_specs
         |     # ./spec/rspec/core/resources/formatter_specs.rb:37
         |     # ./spec/support/formatter_support.rb:41:in `run_rspec_with_formatter'
         |     # ./spec/support/formatter_support.rb:3:in `run_example_specs_with_formatter'
+        |     # ./spec/support/isolated_home_directory.rb:13:in `block (5 levels) in <top (required)>'
+        |     # ./spec/spec_helper.rb:46:in `with_env_vars'
+        |     # ./spec/support/isolated_home_directory.rb:12:in `block (4 levels) in <top (required)>'
+        |     # ./spec/spec_helper.rb:57:in `without_env_vars'
+        |     # ./spec/support/isolated_home_directory.rb:11:in `block (3 levels) in <top (required)>'
+        |     # ./spec/support/isolated_home_directory.rb:7:in `block (2 levels) in <top (required)>'
         |     # ./spec/support/sandboxing.rb:16
         |     # ./spec/support/sandboxing.rb:7
         |
@@ -164,6 +176,12 @@ def expected_summary_output_for_example_specs
         |     # ./spec/rspec/core/resources/formatter_specs.rb:18:in `block (3 levels) in <top (required)>'
         |     # ./spec/support/formatter_support.rb:41:in `run_rspec_with_formatter'
         |     # ./spec/support/formatter_support.rb:3:in `run_example_specs_with_formatter'
+        |     # ./spec/support/isolated_home_directory.rb:13:in `block (5 levels) in <top (required)>'
+        |     # ./spec/spec_helper.rb:46:in `with_env_vars'
+        |     # ./spec/support/isolated_home_directory.rb:12:in `block (4 levels) in <top (required)>'
+        |     # ./spec/spec_helper.rb:57:in `without_env_vars'
+        |     # ./spec/support/isolated_home_directory.rb:11:in `block (3 levels) in <top (required)>'
+        |     # ./spec/support/isolated_home_directory.rb:7:in `block (2 levels) in <top (required)>'
         |     # ./spec/support/sandboxing.rb:16:in `block (3 levels) in <top (required)>'
         |     # ./spec/support/sandboxing.rb:7:in `block (2 levels) in <top (required)>'
         |
@@ -184,6 +202,12 @@ def expected_summary_output_for_example_specs
         |     # ./spec/rspec/core/resources/formatter_specs.rb:37:in `block (2 levels) in <top (required)>'
         |     # ./spec/support/formatter_support.rb:41:in `run_rspec_with_formatter'
         |     # ./spec/support/formatter_support.rb:3:in `run_example_specs_with_formatter'
+        |     # ./spec/support/isolated_home_directory.rb:13:in `block (5 levels) in <top (required)>'
+        |     # ./spec/spec_helper.rb:46:in `with_env_vars'
+        |     # ./spec/support/isolated_home_directory.rb:12:in `block (4 levels) in <top (required)>'
+        |     # ./spec/spec_helper.rb:57:in `without_env_vars'
+        |     # ./spec/support/isolated_home_directory.rb:11:in `block (3 levels) in <top (required)>'
+        |     # ./spec/support/isolated_home_directory.rb:7:in `block (2 levels) in <top (required)>'
         |     # ./spec/support/sandboxing.rb:16:in `block (3 levels) in <top (required)>'
         |     # ./spec/support/sandboxing.rb:7:in `block (2 levels) in <top (required)>'
         |
@@ -215,6 +239,12 @@ def expected_summary_output_for_example_specs
         |     # ./spec/rspec/core/resources/formatter_specs.rb:50:in `block (2 levels) in <top (required)>'
         |     # ./spec/support/formatter_support.rb:41:in `run_rspec_with_formatter'
         |     # ./spec/support/formatter_support.rb:3:in `run_example_specs_with_formatter'
+        |     # ./spec/support/isolated_home_directory.rb:13:in `block (5 levels) in <top (required)>'
+        |     # ./spec/spec_helper.rb:46:in `with_env_vars'
+        |     # ./spec/support/isolated_home_directory.rb:12:in `block (4 levels) in <top (required)>'
+        |     # ./spec/spec_helper.rb:57:in `without_env_vars'
+        |     # ./spec/support/isolated_home_directory.rb:11:in `block (3 levels) in <top (required)>'
+        |     # ./spec/support/isolated_home_directory.rb:7:in `block (2 levels) in <top (required)>'
         |     # ./spec/support/sandboxing.rb:16:in `block (3 levels) in <top (required)>'
         |     # ./spec/support/sandboxing.rb:7:in `block (2 levels) in <top (required)>'
         |