Rename parse_options to options and have it return a memoized value.

The old way was odd. It created an ordering dependency
(you had to call `parse_options` after instantiating the
object but before doing anything else) and calling it a second
time had the side effect of re-parsing the args, which wasn't
needed or intended.

It's far easier/better to make `options` do the parsing
and memoize the result.

Author: myronmarston

lib/rspec/core/command_line.rb

@@ -4,7 +4,6 @@ class CommandLine
       def initialize(options, configuration=RSpec::configuration, world=RSpec::world)
         if Array === options
           options = ConfigurationOptions.new(options)
-          options.parse_options
         end
         @options       = options
         @configuration = configuration

lib/rspec/core/configuration_options.rb

@@ -5,8 +5,6 @@ module RSpec
   module Core
     # @private
     class ConfigurationOptions
-      attr_reader :options
-
       def initialize(args)
         @args = args.map {|a|
           a.sub("default_path", "default-path").sub("line_number",  "line-number")
@@ -20,8 +18,8 @@ def configure(config)
         load_formatters_into config
       end
 
-      def parse_options
-        @options = (file_options << command_line_options << env_options).
+      def options
+        @options ||= (file_options << command_line_options << env_options).
           each {|opts|
             filter_manager.include opts.delete(:inclusion_filter) if opts.has_key?(:inclusion_filter)
             filter_manager.exclude opts.delete(:exclusion_filter) if opts.has_key?(:exclusion_filter)

lib/rspec/core/runner.rb

@@ -87,7 +87,6 @@ def self.trap_interrupt
       def self.run(args, err=$stderr, out=$stdout)
         trap_interrupt
         options = ConfigurationOptions.new(args)
-        options.parse_options
 
         if options.options[:drb]
           require 'rspec/core/drb_command_line'

spec/rspec/core/command_line_spec.rb

@@ -33,7 +33,7 @@ module RSpec::Core
     it "assigns ConfigurationOptions built from Array of options to @options" do
       config_options = ConfigurationOptions.new(%w[--color])
       command_line   = CommandLine.new(%w[--color])
-      expect(command_line.instance_eval { @options.options }).to eq(config_options.parse_options)
+      expect(command_line.instance_eval { @options.options }).to eq(config_options.options)
     end
 
     it "assigns submitted ConfigurationOptions to @options" do
@@ -106,9 +106,7 @@ def build_command_line *args
     end
 
     def build_config_options *args
-      options = ConfigurationOptions.new args
-      options.parse_options
-      options
+      ConfigurationOptions.new args
     end
   end
 end

spec/rspec/core/configuration_options_spec.rb

@@ -8,14 +8,13 @@
   it "warns when HOME env var is not set", :unless => (RUBY_PLATFORM == 'java') do
     without_env_vars 'HOME' do
       expect_warning_with_call_site(__FILE__, __LINE__ + 1)
-      RSpec::Core::ConfigurationOptions.new([]).parse_options
+      RSpec::Core::ConfigurationOptions.new([]).options
     end
   end
 
-  it "duplicates the arguments array" do
+  it "does not mutate the provided args array" do
     args = ['-e', 'some spec']
-    coo = RSpec::Core::ConfigurationOptions.new(args)
-    coo.parse_options
+    RSpec::Core::ConfigurationOptions.new(args).options
     expect(args).to eq(['-e', 'some spec'])
   end
 

spec/rspec/core/drb_command_line_spec.rb

@@ -13,9 +13,7 @@ def command_line(*args)
   end
 
   def config_options(*args)
-    options = RSpec::Core::ConfigurationOptions.new(args)
-    options.parse_options
-    options
+    RSpec::Core::ConfigurationOptions.new(args)
   end
 
   context "without server running" do
@@ -69,7 +67,6 @@ def with_RSPEC_DRB_set_to(val)
     class SimpleDRbSpecServer
       def self.run(argv, err, out)
         options = RSpec::Core::ConfigurationOptions.new(argv)
-        options.parse_options
         config = RSpec::Core::Configuration.new
         RSpec::Core::CommandLine.new(options, config).run(err, out)
       end

spec/support/config_options_helper.rb

@@ -4,9 +4,7 @@ module ConfigOptionsHelper
   around(:each) { |e| without_env_vars('SPEC_OPTS', &e) }
 
   def config_options_object(*args)
-    coo = RSpec::Core::ConfigurationOptions.new(args)
-    coo.parse_options
-    coo
+    RSpec::Core::ConfigurationOptions.new(args)
   end
 
   def parse_options(*args)