Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Commit b9ce89f

Browse files
committed
Document repeated tests with bisect command
1 parent f746452 commit b9ce89f

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

spec/integration/bisect_spec.rb

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,13 @@ def bisect(cli_args, expected_status=nil)
3434
end
3535

3636
context "when the bisect command is long" do
37+
# On OSX and Linux when we have many tests we could had pipe size issue. We did not empty the buffer
38+
# and we ended up with a pipe that was full and it was blocking the main process. This made the bisect
39+
# command stuck without further information. This test run blocking_pipe_bisect_spec.rb_ that
40+
# will ensure that we are not blocked anymore in this kind of situation.
41+
# https://github.com/rspec/rspec-core/pull/2669
3742
it 'does not hit pipe size limit and does not get stuck' do
3843
output = bisect(%W[spec/rspec/core/resources/blocking_pipe_bisect_spec.rb_], 1)
39-
puts output
4044
expect(output).to include("No failures found.")
4145
end
4246
end

0 commit comments

Comments
 (0)