Merge pull request #2783 from rspec/update-ci-build-scripts-2020-11-18-for-main

Updates from rspec-dev (2020-11-18)

Author: JonRowe

.github/workflows/ci.yml

@@ -1,4 +1,4 @@
-# This file was generated on 2020-11-16T22:10:29+00:00 from the rspec-dev repo.
+# This file was generated on 2020-11-18T09:45:41+00:00 from the rspec-dev repo.
 # DO NOT modify it by hand as your changes will get lost the next time it is generated.
 
 name: RSpec CI
@@ -40,3 +40,27 @@ jobs:
       - run: script/clone_all_rspec_repos
       - run: bundle install --binstubs --standalone
       - run: script/run_build
+
+  windows:
+    name: Ruby ${{ matrix.ruby }} (Windows)
+    runs-on: windows-latest
+    strategy:
+      matrix:
+        ruby:
+          - 2.7
+          - 2.6
+          - 2.5
+          - 2.4
+          - 2.3
+          - 2.2
+          - 2.1.9
+      fail-fast: false
+    steps:
+      - uses: actions/checkout@v2
+      - uses: ruby/setup-ruby@v1
+        with:
+          bundler: 2
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+      - run: cinst ansicon
+      - run: bundle exec rspec --backtrace

.rubocop_rspec_base.yml

@@ -1,4 +1,4 @@
-# This file was generated on 2020-11-16T22:10:29+00:00 from the rspec-dev repo.
+# This file was generated on 2020-11-18T09:45:41+00:00 from the rspec-dev repo.
 # DO NOT modify it by hand as your changes will get lost the next time it is generated.
 
 # This file contains defaults for RSpec projects. Individual projects

.travis.yml

@@ -1,4 +1,4 @@
-# This file was generated on 2020-11-16T22:10:29+00:00 from the rspec-dev repo.
+# This file was generated on 2020-11-18T09:45:41+00:00 from the rspec-dev repo.
 # DO NOT modify it by hand as your changes will get lost the next time it is generated.
 
 # In order to install old Rubies, we need to use old Ubuntu distibution.

Gemfile

@@ -44,8 +44,10 @@ if RUBY_VERSION < '2.2.0' && !!(RbConfig::CONFIG['host_os'] =~ /cygwin|mswin|min
   gem 'ffi', '< 1.10'
 elsif RUBY_VERSION < '2.0'
   gem 'ffi', '< 1.9.19' # ffi dropped Ruby 1.8 support in 1.9.19
+elsif RUBY_VERSION < '2.3.0'
+  gem 'ffi', '~> 1.12.0'
 else
-  gem 'ffi', '~> 1.11.0'
+  gem 'ffi', '~> 1.13.0'
 end
 
 if RUBY_VERSION < '2.3.0' && !!(RbConfig::CONFIG['host_os'] =~ /cygwin|mswin|mingw|bccwin|wince|emx/)

appveyor.yml

@@ -1,4 +1,4 @@
-# This file was generated on 2020-11-16T22:10:29+00:00 from the rspec-dev repo.
+# This file was generated on 2020-11-18T09:45:41+00:00 from the rspec-dev repo.
 # DO NOT modify it by hand as your changes will get lost the next time it is generated.
 
 # Taken from:

script/ci_functions.sh

@@ -1,5 +1,5 @@
 #!/bin/bash
-# This file was generated on 2020-11-16T22:10:29+00:00 from the rspec-dev repo.
+# This file was generated on 2020-11-18T09:45:41+00:00 from the rspec-dev repo.
 # DO NOT modify it by hand as your changes will get lost the next time it is generated.
 
 set -e

script/clone_all_rspec_repos

@@ -1,4 +1,4 @@
-# This file was generated on 2020-11-16T22:10:29+00:00 from the rspec-dev repo.
+# This file was generated on 2020-11-18T09:45:41+00:00 from the rspec-dev repo.
 # DO NOT modify it by hand as your changes will get lost the next time it is generated.
 
 SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"

script/functions.sh

@@ -1,4 +1,4 @@
-# This file was generated on 2020-11-16T22:10:29+00:00 from the rspec-dev repo.
+# This file was generated on 2020-11-18T09:45:41+00:00 from the rspec-dev repo.
 # DO NOT modify it by hand as your changes will get lost the next time it is generated.
 
 function is_mri {

script/predicate_functions.sh

@@ -1,5 +1,5 @@
 #!/bin/bash
-# This file was generated on 2020-11-16T22:10:29+00:00 from the rspec-dev repo.
+# This file was generated on 2020-11-18T09:45:41+00:00 from the rspec-dev repo.
 # DO NOT modify it by hand as your changes will get lost the next time it is generated.
 
 set -e

script/run_build

@@ -1,5 +1,5 @@
 #!/bin/bash
-# This file was generated on 2020-11-16T22:10:29+00:00 from the rspec-dev repo.
+# This file was generated on 2020-11-18T09:45:41+00:00 from the rspec-dev repo.
 # DO NOT modify it by hand as your changes will get lost the next time it is generated.
 
 set -e

script/update_rubygems_and_install_bundler

@@ -4,10 +4,6 @@ module RSpec::Core
   RSpec.describe "Bisect", :slow, :simulate_shell_allowing_unquoted_ids do
     include FormatterSupport
 
-    before do
-      skip "These specs do not consistently pass or fail on AppVeyor on Ruby 2.1+"
-    end if ENV['APPVEYOR'] && RUBY_VERSION.to_f > 2.0
-
     def bisect(cli_args, expected_status=nil)
       options = ConfigurationOptions.new(cli_args)
 

spec/integration/bisect_spec.rb

@@ -535,9 +535,7 @@ def stub_expectation_adapters
         expect(config.files_to_run).to contain_files("./spec/rspec/core/resources/a_spec.rb")
       end
 
-      it "supports absolute path patterns", :failing_on_appveyor,
-        :pending => false,
-        :skip => (ENV['APPVEYOR'] ? "Failing on AppVeyor but :pending isn't working for some reason" : false) do
+      it "supports absolute path patterns", :emits_warning_on_windows_on_old_ruby do
         dir = File.expand_path("../resources", __FILE__)
         config.pattern = File.join(dir, "**/*_spec.rb")
         assign_files_or_directories_to_run "spec"
@@ -618,7 +616,7 @@ def stub_expectation_adapters
           expect(config.files_to_run).to contain_files("C:/path/to/project/spec/sub/foo_spec.rb")
         end
 
-        it "loads files in Windows when directory is specified", :failing_on_appveyor, :if => RSpec::Support::OS.windows? do
+        it "loads files in Windows when directory is specified", :failing_on_windows_ci, :if => RSpec::Support::OS.windows? do
           assign_files_or_directories_to_run "spec\\rspec\\core\\resources"
           expect(config.files_to_run).to contain_files("spec/rspec/core/resources/a_spec.rb")
         end

spec/rspec/core/configuration_spec.rb

@@ -308,9 +308,7 @@ def self.it_configures_rspec_load_path(description, path_template)
       end
 
       context "that is an absolute path file glob" do
-        it "loads the matching spec files", :failing_on_appveyor,
-        :pending => false,
-        :skip => (ENV['APPVEYOR'] ? "Failing on AppVeyor but :pending isn't working for some reason" : false) do
+        it "loads the matching spec files", :emits_warning_on_windows_on_old_ruby, :pending_on_windows_old_ruby do
           dir = File.expand_path("../resources", __FILE__)
           task.pattern = File.join(dir, "**/*_spec.rb")
 
@@ -443,7 +441,7 @@ def make_files_in_dir(dir)
     context "with paths with quotes or spaces" do
       include_context "isolated directory"
 
-      it "matches files with quotes and spaces", :failing_on_appveyor do
+      it "matches files with quotes and spaces", :failing_on_windows_ci do
         spec_dir = File.join(Dir.getwd, "spec")
         task.pattern = "spec/*spec.rb"
         FileUtils.mkdir_p(spec_dir)

spec/rspec/core/rake_task_spec.rb

@@ -97,6 +97,16 @@ def handle_current_dir_change
     with_env_vars('SHELL' => '/usr/local/bin/bash', &ex)
   end
 
+  if ENV['CI'] && RSpec::Support::OS.windows? && RUBY_VERSION.to_f < 2.3
+    c.around(:example, :emits_warning_on_windows_on_old_ruby) do |ex|
+      ignoring_warnings(&ex)
+    end
+
+    c.define_derived_metadata(:pending_on_windows_old_ruby => true) do |metadata|
+      metadata[:pending] = "This example is expected to fail on windows, on ruby older than 2.3"
+    end
+  end
+
   c.filter_run_excluding :ruby => lambda {|version|
     case version.to_s
     when "!jruby"