Address code review feedback.

- s/exception/example/ in a comment
- Do not run later `before(:suite)` hooks when an earlier
  one has failed. This aligns with `before(:example)` and
  `before(:context)` hooks.  However, `after(:suite)` hooks
  all get run even if one fails, which again aligns with
  `after(:example)` and `after(:suite)` hooks.

Author: myronmarston

lib/rspec/core/configuration.rb

@@ -1887,6 +1887,12 @@ def run_suite_hooks(hook_description, hooks)
             hook.run(context)
           rescue Support::AllExceptionsExceptOnesWeMustNotRescue => ex
             context.set_exception(ex)
+
+            # Do not run subsequent `before` hooks if one fails.
+            # But for `after` hooks, we run them all so that all
+            # cleanup bits get a chance to complete, minimizing the
+            # chance that resources get left behind.
+            break if hooks.equal?(@before_suite_hooks)
           end
         end
       end

lib/rspec/core/reporter.rb

@@ -153,7 +153,7 @@ def deprecation(hash)
 
     # @private
     # Provides a way to notify of an exception that is not tied to any
-    # particular exception (such as an exception encountered in a :suite hook).
+    # particular example (such as an exception encountered in a :suite hook).
     # Exceptions will be formatted the same way they normally are.
     def notify_non_example_exception(exception, context_description)
       @configuration.world.non_example_failure = true

spec/integration/suite_hooks_errors_spec.rb

@@ -110,13 +110,6 @@ def run_spec_expecting_non_zero(before_or_after)
         before 1
       # ./the_spec.rb:3#{spec_line_suffix}
 
-      An error occurred in a `before(:suite)` hook.
-      Failure/Error: c.before(:suite) { raise 'before 2' }
-
-      RuntimeError:
-        before 2
-      # ./the_spec.rb:4#{spec_line_suffix}
-
       An error occurred in an `after(:suite)` hook.
       Failure/Error: c.after(:suite) { raise 'after 2' }
 

spec/rspec/core/hooks_spec.rb

@@ -18,6 +18,64 @@ def hook_collection_for(position, scope)
       end
     end
 
+    [:example, :context, :suite].each do |scope|
+      describe "#before(#{scope})" do
+        it "stops running subsequent hooks of the same type when an error is encountered" do
+          sequence = []
+
+          RSpec.configure do |c|
+            c.output_stream = StringIO.new
+
+            c.before(scope) do
+              sequence << :hook_1
+              raise "boom"
+            end
+
+            c.before(scope) do
+              sequence << :hook_2
+              raise "boom"
+            end
+          end
+
+          RSpec.configuration.with_suite_hooks do
+            RSpec.describe do
+              example { sequence << :example }
+            end.run
+          end
+
+          expect(sequence).to eq [:hook_1]
+        end
+      end
+
+      describe "#after(#{scope})" do
+        it "runs subsequent hooks of the same type when an error is encountered so all cleanup can complete" do
+          sequence = []
+
+          RSpec.configure do |c|
+            c.output_stream = StringIO.new
+
+            c.after(scope) do
+              sequence << :hook_2
+              raise "boom"
+            end
+
+            c.after(scope) do
+              sequence << :hook_1
+              raise "boom"
+            end
+          end
+
+          RSpec.configuration.with_suite_hooks do
+            RSpec.describe do
+              example { sequence << :example }
+            end.run
+          end
+
+          expect(sequence).to eq [:example, :hook_1, :hook_2]
+        end
+      end
+    end
+
     [:before, :after, :around].each do |type|
       [:example, :context].each do |scope|
         next if type == :around && scope == :context