Rename attribute.

The “in execution order” part isn’t actually important
for how we are using it, and makes the name unnecessarily
long.

Author: myronmarston

lib/rspec/core/bisect/example_minimizer.rb

@@ -7,7 +7,7 @@ module Bisect
       # Contains the core bisect logic. Searches for examples we can ignore by
       # repeatedly running different subsets of the suite.
       class ExampleMinimizer
-        attr_reader :runner, :reporter, :all_example_ids_in_execution_order, :failed_example_ids
+        attr_reader :runner, :reporter, :all_example_ids, :failed_example_ids
 
         def initialize(runner, reporter)
           @runner   = runner
@@ -17,7 +17,7 @@ def initialize(runner, reporter)
         def find_minimal_repro
           prep
 
-          remaining_ids = all_example_ids_in_execution_order - failed_example_ids
+          remaining_ids = all_example_ids - failed_example_ids
           debug 0, "Initial failed_example_ids: #{failed_example_ids}"
           debug 0, "Initial remaining_ids: #{remaining_ids}"
 
@@ -41,8 +41,8 @@ def prep
           notify(:bisect_starting, :original_cli_args => runner.original_cli_args)
 
           _, duration = track_duration do
-            original_results = runner.original_results
-            @all_example_ids_in_execution_order = original_results.all_example_ids_in_execution_order
+            original_results    = runner.original_results
+            @all_example_ids    = original_results.all_example_ids
             @failed_example_ids = original_results.failed_example_ids
           end
 
@@ -52,7 +52,7 @@ def prep
         end
 
         def non_failing_example_ids
-          @non_failing_example_ids ||= all_example_ids_in_execution_order - failed_example_ids
+          @non_failing_example_ids ||= all_example_ids - failed_example_ids
         end
 
         def get_same_failures?(ids)

lib/rspec/core/formatters/bisect_formatter.rb

@@ -51,8 +51,7 @@ def start_dump(_notification)
           )
         end
 
-        RunResults = Struct.new(:all_example_ids_in_execution_order,
-                                :failed_example_ids)
+        RunResults = Struct.new(:all_example_ids, :failed_example_ids)
 
       private
 

spec/rspec/core/bisect/server_spec.rb

@@ -49,7 +49,7 @@ def run_formatter_specs
         end
 
         expect(results).to have_attributes(
-          :all_example_ids_in_execution_order => %w[
+          :all_example_ids => %w[
             ./spec/rspec/core/resources/formatter_specs.rb[1:1]
             ./spec/rspec/core/resources/formatter_specs.rb[2:1:1]
             ./spec/rspec/core/resources/formatter_specs.rb[2:2:1]
@@ -73,7 +73,7 @@ def run_formatter_specs
         end
 
         expect(results).to have_attributes(
-          :all_example_ids_in_execution_order => %w[
+          :all_example_ids => %w[
             ./spec/rspec/core/resources/formatter_specs.rb[1:1]
             ./spec/rspec/core/resources/formatter_specs.rb[2:1:1]
             ./spec/rspec/core/resources/formatter_specs.rb[2:2:1]