Less certainty in bisect dependency check output

Since we can't consider the dependency check to have proved the existence of
an order-dependent failure, make the output less categorical.

Author: urbanautomaton

features/command_line/bisect.feature

@@ -54,7 +54,7 @@ Feature: Bisect
       Bisect started using options: "--seed 1234"
       Running suite to find failures... (0.16755 seconds)
       Starting bisect with 1 failing example and 9 non-failing examples.
-      Checking that failures are order-dependent... failure is order-dependent
+      Checking that failure(s) are order-dependent... failure appears to be order-dependent
 
       Bisecting over non-failing examples 1-9 .. ignoring examples 6-9 (0.30166 seconds)
       Bisecting over non-failing examples 1-5 .. ignoring examples 4-5 (0.30306 seconds)
@@ -75,7 +75,7 @@ Feature: Bisect
       Bisect started using options: "--seed 1234"
       Running suite to find failures... (0.17102 seconds)
       Starting bisect with 1 failing example and 9 non-failing examples.
-      Checking that failures are order-dependent... failure is order-dependent
+      Checking that failure(s) are order-dependent... failure appears to be order-dependent
 
       Bisecting over non-failing examples 1-9 .. ignoring examples 6-9 (0.32943 seconds)
       Bisecting over non-failing examples 1-5 .. ignoring examples 4-5 (0.3154 seconds)
@@ -107,8 +107,8 @@ Feature: Bisect
           - ./spec/calculator_7_spec.rb[1:1]
           - ./spec/calculator_8_spec.rb[1:1]
           - ./spec/calculator_9_spec.rb[1:1]
-      Checking that failures are order-dependent..
-       - Running: rspec ./spec/calculator_1_spec.rb[1:1] --seed 1234 (n.nnnn seconds) failure is order-dependent
+      Checking that failure(s) are order-dependent..
+       - Running: rspec ./spec/calculator_1_spec.rb[1:1] --seed 1234 (n.nnnn seconds) failure appears to be order-dependent
 
       Bisecting over non-failing examples 1-9
        - Running: rspec ./spec/calculator_1_spec.rb[1:1] ./spec/calculator_6_spec.rb[1:1] ./spec/calculator_7_spec.rb[1:1] ./spec/calculator_8_spec.rb[1:1] ./spec/calculator_9_spec.rb[1:1] --seed 1234 (0.15302 seconds)

lib/rspec/core/bisect/example_minimizer.rb

@@ -30,11 +30,11 @@ def find_minimal_repro
         def bisect(candidate_ids)
           notify(:bisect_dependency_check_started)
           if get_expected_failures_for?([])
-            notify(:bisect_dependency_check_finished, :dependent_failures => false)
+            notify(:bisect_dependency_check_failed)
             self.remaining_ids = []
             return
           end
-          notify(:bisect_dependency_check_finished, :dependent_failures => true)
+          notify(:bisect_dependency_check_passed)
 
           bisect_over(candidate_ids)
         end

lib/rspec/core/formatters/bisect_progress_formatter.rb

@@ -11,8 +11,8 @@ class BisectProgressFormatter < BaseTextFormatter
                             :bisect_round_started, :bisect_individual_run_complete,
                             :bisect_complete, :bisect_repro_command,
                             :bisect_failed, :bisect_aborted, :bisect_ignoring_ids,
-                            :bisect_dependency_check_started, :bisect_dependency_check_finished,
-                            :bisect_multiple_culprits_detected
+                            :bisect_dependency_check_started, :bisect_dependency_check_passed,
+                            :bisect_dependency_check_failed, :bisect_multiple_culprits_detected
 
         def bisect_starting(notification)
           options = notification.original_cli_args.join(' ')
@@ -29,12 +29,15 @@ def bisect_original_run_complete(notification)
         end
 
         def bisect_dependency_check_started(_notification)
-          output.print "Checking that failures are order-dependent.."
+          output.print "Checking that failure(s) are order-dependent.."
         end
 
-        def bisect_dependency_check_finished(notification)
-          is_part = notification.dependent_failures ? "is" : "is not"
-          output.puts " failure #{is_part} order-dependent"
+        def bisect_dependency_check_passed(notification)
+          output.puts " failure appears to be order-dependent"
+        end
+
+        def bisect_dependency_check_failed(notification)
+          output.puts " failure is not order-dependent"
         end
 
         def bisect_round_started(notification, include_trailing_space=true)

spec/rspec/core/bisect/coordinator_spec.rb

@@ -34,7 +34,7 @@ def find_minimal_repro(output, formatter=Formatters::BisectProgressFormatter)
         |Bisect started using options: ""
         |Running suite to find failures... (n.nnnn seconds)
         |Starting bisect with 2 failing examples and 6 non-failing examples.
-        |Checking that failures are order-dependent... failure is order-dependent
+        |Checking that failure(s) are order-dependent... failure appears to be order-dependent
         |
         |Bisecting over non-failing examples 1-6 .. ignoring examples 4-6 (n.nnnn seconds)
         |Bisecting over non-failing examples 1-3 .. multiple culprits detected - splitting candidates (n.nnnn seconds)
@@ -56,7 +56,7 @@ def find_minimal_repro(output, formatter=Formatters::BisectProgressFormatter)
         |Bisect started using options: ""
         |Running suite to find failures... (n.nnnn seconds)
         |Starting bisect with 1 failing example and 7 non-failing examples.
-        |Checking that failures are order-dependent... failure is not order-dependent
+        |Checking that failure(s) are order-dependent... failure is not order-dependent
         |
         |Bisect complete! Reduced necessary non-failing examples from 7 to 0 in n.nnnn seconds.
         |
@@ -83,8 +83,8 @@ def find_minimal_repro(output, formatter=Formatters::BisectProgressFormatter)
         |    - 6.rb[1:1]
         |    - 7.rb[1:1]
         |    - 8.rb[1:1]
-        |Checking that failures are order-dependent..
-        | - Running: rspec 2.rb[1:1] 5.rb[1:1] (n.nnnn seconds) failure is order-dependent
+        |Checking that failure(s) are order-dependent..
+        | - Running: rspec 2.rb[1:1] 5.rb[1:1] (n.nnnn seconds) failure appears to be order-dependent
         |
         |Bisecting over non-failing examples 1-6
         | - Running: rspec 2.rb[1:1] 5.rb[1:1] 6.rb[1:1] 7.rb[1:1] 8.rb[1:1] (n.nnnn seconds)
@@ -150,7 +150,7 @@ def bisect_round_started(notification)
           |Bisect started using options: ""
           |Running suite to find failures... (n.nnnn seconds)
           |Starting bisect with 2 failing examples and 6 non-failing examples.
-          |Checking that failures are order-dependent... failure is order-dependent
+          |Checking that failure(s) are order-dependent... failure appears to be order-dependent
           |
           |Bisecting over non-failing examples 1-6 .. ignoring examples 4-6 (n.nnnn seconds)
           |