Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Commit f19728c

Browse files
author
Tim Mertens
committed
Refactor metadata_filter to make rubocop pass.
1 parent c3daffc commit f19728c

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

lib/rspec/core/metadata_filter.rb

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,7 @@ def filter_applies?(key, value, metadata)
2727
when Regexp
2828
metadata[key] =~ value
2929
when Proc
30-
case value.arity
31-
when 0 then value.call
32-
when 2 then value.call(metadata[key], metadata)
33-
else value.call(metadata[key])
34-
end
30+
proc_filter_applies?(key, value, metadata)
3531
else
3632
metadata[key].to_s == value.to_s
3733
end
@@ -62,6 +58,14 @@ def line_number_filter_applies?(line_numbers, metadata)
6258
!(relevant_line_numbers(metadata) & preceding_declaration_lines).empty?
6359
end
6460

61+
def proc_filter_applies?(key, proc, metadata)
62+
case proc.arity
63+
when 0 then proc.call
64+
when 2 then proc.call(metadata[key], metadata)
65+
else proc.call(metadata[key])
66+
end
67+
end
68+
6569
def relevant_line_numbers(metadata)
6670
Metadata.ascend(metadata).map { |meta| meta[:line_number] }
6771
end

0 commit comments

Comments
 (0)