Rename SnippetExtractor to HtmlSnippetExtractor

Author: yujinakayama

lib/rspec/core/formatters/html_formatter.rb

@@ -137,12 +137,12 @@ def percent_done
         # spec. For example, you could output links to images or other files
         # produced during the specs.
         def extra_failure_content(failure)
-          RSpec::Support.require_rspec_core "formatters/snippet_extractor"
+          RSpec::Support.require_rspec_core "formatters/html_snippet_extractor"
           backtrace = (failure.exception.backtrace || []).map do |line|
             RSpec.configuration.backtrace_formatter.backtrace_line(line)
           end
           backtrace.compact!
-          @snippet_extractor ||= SnippetExtractor.new
+          @snippet_extractor ||= HtmlSnippetExtractor.new
           "    <pre class=\"ruby\"><code>#{@snippet_extractor.snippet(backtrace)}</code></pre>"
         end
       end

lib/rspec/core/formatters/snippet_extractor.rb renamed to lib/rspec/core/formatters/html_snippet_extractor.rb

@@ -5,7 +5,7 @@ module Formatters
       #
       # Extracts code snippets by looking at the backtrace of the passed error
       # and applies synax highlighting and line numbers using html.
-      class SnippetExtractor
+      class HtmlSnippetExtractor
         # @private
         module NullConverter
           def self.convert(code)

spec/rspec/core/formatters/snippet_extractor_spec.rb renamed to spec/rspec/core/formatters/html_snippet_extractor_spec.rb

@@ -1,41 +1,41 @@
-require 'rspec/core/formatters/snippet_extractor'
+require 'rspec/core/formatters/html_snippet_extractor'
 
 module RSpec
   module Core
     module Formatters
-      RSpec.describe SnippetExtractor do
+      RSpec.describe HtmlSnippetExtractor do
         it "falls back on a default message when it doesn't understand a line" do
-          expect(RSpec::Core::Formatters::SnippetExtractor.new.snippet_for("blech")).to eq(["# Couldn't get snippet for blech", 1])
+          expect(RSpec::Core::Formatters::HtmlSnippetExtractor.new.snippet_for("blech")).to eq(["# Couldn't get snippet for blech", 1])
         end
 
         it "falls back on a default message when it doesn't find the file" do
-          expect(RSpec::Core::Formatters::SnippetExtractor.new.lines_around("blech", 8)).to eq("# Couldn't get snippet for blech")
+          expect(RSpec::Core::Formatters::HtmlSnippetExtractor.new.lines_around("blech", 8)).to eq("# Couldn't get snippet for blech")
         end
 
         it "falls back on a default message when it gets a security error" do
           message = nil
           with_safe_set_to_level_that_triggers_security_errors do
-            message = RSpec::Core::Formatters::SnippetExtractor.new.lines_around("blech", 8)
+            message = RSpec::Core::Formatters::HtmlSnippetExtractor.new.lines_around("blech", 8)
           end
           expect(message).to eq("# Couldn't get snippet for blech")
         end
 
         describe "snippet extraction" do
           let(:snippet) do
-            SnippetExtractor.new.snippet(["#{__FILE__}:#{__LINE__}"])
+            HtmlSnippetExtractor.new.snippet(["#{__FILE__}:#{__LINE__}"])
           end
 
           before do
             # `send` is required for 1.8.7...
-            @orig_converter = SnippetExtractor.send(:class_variable_get, :@@converter)
+            @orig_converter = HtmlSnippetExtractor.send(:class_variable_get, :@@converter)
           end
 
           after do
-            SnippetExtractor.send(:class_variable_set, :@@converter, @orig_converter)
+            HtmlSnippetExtractor.send(:class_variable_set, :@@converter, @orig_converter)
           end
 
           it 'suggests you install coderay when it cannot be loaded' do
-            SnippetExtractor.send(:class_variable_set, :@@converter, SnippetExtractor::NullConverter)
+            HtmlSnippetExtractor.send(:class_variable_set, :@@converter, HtmlSnippetExtractor::NullConverter)
 
             expect(snippet).to include("Install the coderay gem")
           end