Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Commit ff181eb

Browse files
committed
Remove treat_symbols_as_metadata_keys_with_true_values
1 parent 7cec8f4 commit ff181eb

File tree

3 files changed

+2
-19
lines changed

3 files changed

+2
-19
lines changed

Changelog.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ Breaking Changes:
2020
* Remove deprecated `color` configuration option. (Phil Pirozhkov, #2864)
2121
* Remove `it_should_behave_like` nested shared group method and
2222
`alias_it_should_behave_like_to` configuration option. (Phil Pirozhkov, #2864)
23+
* Remove deprecated `treat_symbols_as_metadata_keys_with_true_values` configuration
24+
option. (Phil Pirozhkov, #2864)
2325

2426
Enhancements:
2527

lib/rspec/core/configuration.rb

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -348,18 +348,6 @@ def exclude_pattern=(value)
348348
# return [Boolean]
349349
add_setting :silence_filter_announcements
350350

351-
# @deprecated This config option was added in RSpec 2 to pave the way
352-
# for this being the default behavior in RSpec 3. Now this option is
353-
# a no-op.
354-
def treat_symbols_as_metadata_keys_with_true_values=(_value)
355-
RSpec.deprecate(
356-
"RSpec::Core::Configuration#treat_symbols_as_metadata_keys_with_true_values=",
357-
:message => "RSpec::Core::Configuration#treat_symbols_as_metadata_keys_with_true_values= " \
358-
"is deprecated, it is now set to true as default and " \
359-
"setting it to false has no effect."
360-
)
361-
end
362-
363351
# Record the start time of the spec suite to measure load time.
364352
# return [Time]
365353
add_setting :start_time

spec/rspec/core/configuration_spec.rb

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1583,13 +1583,6 @@ def metadata_hash(*args)
15831583
it_behaves_like "a spec filter", :inclusion_filter
15841584
it_behaves_like "a spec filter", :exclusion_filter
15851585

1586-
describe "#treat_symbols_as_metadata_keys_with_true_values=" do
1587-
it 'is deprecated' do
1588-
expect_deprecation_with_call_site(__FILE__, __LINE__ + 1)
1589-
config.treat_symbols_as_metadata_keys_with_true_values = true
1590-
end
1591-
end
1592-
15931586
describe "#full_backtrace=" do
15941587
it "doesn't impact other instances of config" do
15951588
config_1 = Configuration.new

0 commit comments

Comments
 (0)