This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Turn a #map into #each where the return value is unused #2111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The return value of RubyProject.add_to_load_path is neither useful nor used anywhere. In this case, #each communicates intent better than #map.
soulcutter
added a commit
that referenced
this pull request
Nov 9, 2015
Turn a #map into #each where the return value is unused
|
Looks good to me |
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
Turn a #map into #each where the return value is unused
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return value of
RubyProject.add_to_load_pathis neither useful nor used anywhere. In this case,#eachcommunicates intent better than#map.Shout out to @scottmatthewman for highlighting this method at the November 2015 meeting of the London Ruby User Group.