validate arguments to and_invoke

Author: askreet

lib/rspec/mocks/message_expectation.rb

@@ -117,6 +117,10 @@ def and_invoke(first_proc, *procs)
         end
 
         procs.unshift(first_proc)
+        if procs.any? { |p| !p.respond_to?(:call) }
+          raise ArgumentError, "Arguments to `and_invoke` must be callable."
+        end
+
         @expected_received_count = [@expected_received_count, procs.size].max unless ignoring_args? || (@expected_received_count == 0 && @at_least)
         self.terminal_implementation_action = AndInvokeImplementation.new(procs)
 

spec/rspec/mocks/and_invoke_spec.rb

@@ -16,6 +16,18 @@ module Mocks
           expect { allow(obj).to receive(:foo).and_invoke }.to raise_error(ArgumentError)
         end
       end
+
+      context 'when a non-callable are passed in any position' do
+        let(:non_callable) { nil }
+        let(:callable) { lambda { nil } }
+
+        it 'raises ArgumentError' do
+          expect { allow(obj).to receive(:foo).and_invoke(non_callable) }
+            .to raise_error(ArgumentError, "Arguments to `and_invoke` must be callable.")
+          expect { allow(obj).to receive(:foo).and_invoke(callable, non_callable) }
+            .to raise_error(ArgumentError, "Arguments to `and_invoke` must be callable.")
+        end
+      end
     end
   end
 end