Split out Rubocop into a dedicated job and only run once

Author: petergoldstein

.github/workflows/ci.yml

@@ -9,6 +9,20 @@ on:
     branches:
       - '*'
 jobs:
+  rubocop:
+    name: Rubocop
+    runs-on: 'ubuntu-20.04'
+    steps:
+      - uses: actions/checkout@v2
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: '3.0'
+      - run: script/update_rubygems_and_install_bundler
+      - run: script/clone_all_rspec_repos
+      - run: bundle install --standalone
+      - run: bundle binstubs --all
+      - run: script/run_rubocop
+
   test:
     name: 'Ruby: ${{ matrix.ruby }}, Rails: ${{ matrix.env.RAILS_VERSION }}'
     runs-on: ubuntu-20.04

script/predicate_functions.sh

@@ -97,11 +97,3 @@ function documentation_enforced {
     return 1
   fi
 }
-
-function style_and_lint_enforced {
- if [ -x ./bin/rubocop ]; then
-   return 0
- else
-   return 1
- fi
-}

script/run_build

@@ -26,10 +26,6 @@ if documentation_enforced; then
   fold "doc check" check_documentation_coverage
 fi
 
-if style_and_lint_enforced; then
-  fold "rubocop" check_style_and_lint
-fi
-
 if is_mri; then
   fold "one-by-one specs" run_specs_one_by_one
   run_all_spec_suites