Remove assign and template specs

This removes all expectations for assigns and templates rendered. These fail under a vanilla Rails 5 installation because they've been extracted into the `rails-controller-testing` gem.

Author: Josh Justice

lib/generators/rspec/scaffold/templates/controller_spec.rb

@@ -39,16 +39,6 @@
 
 <% unless options[:singleton] -%>
   describe "GET #index" do
-    it "assigns all <%= table_name.pluralize %> as @<%= table_name.pluralize %>" do
-      <%= file_name %> = <%= class_name %>.create! valid_attributes
-<% if RUBY_VERSION < '1.9.3' -%>
-      get :index, {}, valid_session
-<% else -%>
-      get :index, params: {}, session: valid_session
-<% end -%>
-      expect(assigns(:<%= table_name %>)).to eq([<%= file_name %>])
-    end
-
     it "returns a success response" do
       <%= file_name %> = <%= class_name %>.create! valid_attributes
 <% if RUBY_VERSION < '1.9.3' -%>
@@ -62,16 +52,6 @@
 
 <% end -%>
   describe "GET #show" do
-    it "assigns the requested <%= ns_file_name %> as @<%= ns_file_name %>" do
-      <%= file_name %> = <%= class_name %>.create! valid_attributes
-<% if RUBY_VERSION < '1.9.3' -%>
-      get :show, {:id => <%= file_name %>.to_param}, valid_session
-<% else -%>
-      get :show, params: {id: <%= file_name %>.to_param}, session: valid_session
-<% end -%>
-      expect(assigns(:<%= ns_file_name %>)).to eq(<%= file_name %>)
-    end
-
     it "returns a success response" do
       <%= file_name %> = <%= class_name %>.create! valid_attributes
 <% if RUBY_VERSION < '1.9.3' -%>
@@ -84,15 +64,6 @@
   end
 
   describe "GET #new" do
-    it "assigns a new <%= ns_file_name %> as @<%= ns_file_name %>" do
-<% if RUBY_VERSION < '1.9.3' -%>
-      get :new, {}, valid_session
-<% else -%>
-      get :new, params: {}, session: valid_session
-<% end -%>
-      expect(assigns(:<%= ns_file_name %>)).to be_a_new(<%= class_name %>)
-    end
-
     it "returns a success response" do
 <% if RUBY_VERSION < '1.9.3' -%>
       get :new, {}, valid_session
@@ -104,16 +75,6 @@
   end
 
   describe "GET #edit" do
-    it "assigns the requested <%= ns_file_name %> as @<%= ns_file_name %>" do
-      <%= file_name %> = <%= class_name %>.create! valid_attributes
-<% if RUBY_VERSION < '1.9.3' -%>
-      get :edit, {:id => <%= file_name %>.to_param}, valid_session
-<% else -%>
-      get :edit, params: {id: <%= file_name %>.to_param}, session: valid_session
-<% end -%>
-      expect(assigns(:<%= ns_file_name %>)).to eq(<%= file_name %>)
-    end
-
     it "returns a success response" do
       <%= file_name %> = <%= class_name %>.create! valid_attributes
 <% if RUBY_VERSION < '1.9.3' -%>
@@ -137,16 +98,6 @@
         }.to change(<%= class_name %>, :count).by(1)
       end
 
-      it "assigns a newly created <%= ns_file_name %> as @<%= ns_file_name %>" do
-<% if RUBY_VERSION < '1.9.3' -%>
-        post :create, {:<%= ns_file_name %> => valid_attributes}, valid_session
-<% else -%>
-        post :create, params: {<%= ns_file_name %>: valid_attributes}, session: valid_session
-<% end -%>
-        expect(assigns(:<%= ns_file_name %>)).to be_a(<%= class_name %>)
-        expect(assigns(:<%= ns_file_name %>)).to be_persisted
-      end
-
       it "redirects to the created <%= ns_file_name %>" do
 <% if RUBY_VERSION < '1.9.3' -%>
         post :create, {:<%= ns_file_name %> => valid_attributes}, valid_session
@@ -158,15 +109,6 @@
     end
 
     context "with invalid params" do
-      it "assigns a newly created but unsaved <%= ns_file_name %> as @<%= ns_file_name %>" do
-<% if RUBY_VERSION < '1.9.3' -%>
-        post :create, {:<%= ns_file_name %> => invalid_attributes}, valid_session
-<% else -%>
-        post :create, params: {<%= ns_file_name %>: invalid_attributes}, session: valid_session
-<% end -%>
-        expect(assigns(:<%= ns_file_name %>)).to be_a_new(<%= class_name %>)
-      end
-
       it "returns a success response (i.e. to display the 'new' template)" do
 <% if RUBY_VERSION < '1.9.3' -%>
         post :create, {:<%= ns_file_name %> => invalid_attributes}, valid_session
@@ -175,15 +117,6 @@
 <% end -%>
         expect(response).to be_success
       end
-
-      it "re-renders the 'new' template" do
-<% if RUBY_VERSION < '1.9.3' -%>
-        post :create, {:<%= ns_file_name %> => invalid_attributes}, valid_session
-<% else -%>
-        post :create, params: {<%= ns_file_name %>: invalid_attributes}, session: valid_session
-<% end -%>
-        expect(response).to render_template("new")
-      end
     end
   end
 
@@ -204,16 +137,6 @@
         skip("Add assertions for updated state")
       end
 
-      it "assigns the requested <%= ns_file_name %> as @<%= ns_file_name %>" do
-        <%= file_name %> = <%= class_name %>.create! valid_attributes
-<% if RUBY_VERSION < '1.9.3' -%>
-        put :update, {:id => <%= file_name %>.to_param, :<%= ns_file_name %> => valid_attributes}, valid_session
-<% else -%>
-        put :update, params: {id: <%= file_name %>.to_param, <%= ns_file_name %>: valid_attributes}, session: valid_session
-<% end -%>
-        expect(assigns(:<%= ns_file_name %>)).to eq(<%= file_name %>)
-      end
-
       it "redirects to the <%= ns_file_name %>" do
         <%= file_name %> = <%= class_name %>.create! valid_attributes
 <% if RUBY_VERSION < '1.9.3' -%>
@@ -226,16 +149,6 @@
     end
 
     context "with invalid params" do
-      it "assigns the <%= ns_file_name %> as @<%= ns_file_name %>" do
-        <%= file_name %> = <%= class_name %>.create! valid_attributes
-<% if RUBY_VERSION < '1.9.3' -%>
-        put :update, {:id => <%= file_name %>.to_param, :<%= ns_file_name %> => invalid_attributes}, valid_session
-<% else -%>
-        put :update, params: {id: <%= file_name %>.to_param, <%= ns_file_name %>: invalid_attributes}, session: valid_session
-<% end -%>
-        expect(assigns(:<%= ns_file_name %>)).to eq(<%= file_name %>)
-      end
-
       it "returns a success response (i.e. to display the 'edit' template)" do
         <%= file_name %> = <%= class_name %>.create! valid_attributes
 <% if RUBY_VERSION < '1.9.3' -%>
@@ -245,16 +158,6 @@
 <% end -%>
         expect(response).to be_success
       end
-
-      it "re-renders the 'edit' template" do
-        <%= file_name %> = <%= class_name %>.create! valid_attributes
-<% if RUBY_VERSION < '1.9.3' -%>
-        put :update, {:id => <%= file_name %>.to_param, :<%= ns_file_name %> => invalid_attributes}, valid_session
-<% else -%>
-        put :update, params: {id: <%= file_name %>.to_param, <%= ns_file_name %>: invalid_attributes}, session: valid_session
-<% end -%>
-        expect(response).to render_template("edit")
-      end
     end
   end