Switch SpaceInsideHashLiteralBraces to no_space

Author: pirj

.rubocop.yml

@@ -63,7 +63,7 @@ Layout/ParameterAlignment:
 
 Layout/SpaceInsideHashLiteralBraces:
   EnforcedStyle: no_space
-  EnforcedStyleForEmptyBraces: space
+  EnforcedStyleForEmptyBraces: no_space
 
 Layout/SpaceInsidePercentLiteralDelimiters:
   Enabled: false

example_app_generator/no_active_record/app/models/in_memory/model.rb

@@ -21,7 +21,7 @@ def find(id)
       all.find { |record| record.id == id } || raise
     end
 
-    def create!(attributes = { })
+    def create!(attributes = {})
       record = new(attributes)
       record.save
       record
@@ -43,7 +43,7 @@ class Model
       include ::ActiveModel::Conversion
       include ::ActiveModel::Validations
 
-      def initialize(attributes = { })
+      def initialize(attributes = {})
         assign_attributes(attributes)
       end
     end

example_app_generator/spec/verify_custom_renderers_spec.rb

@@ -138,7 +138,7 @@ def index
   class MyResolver < ActionView::Resolver
     private
 
-    def find_templates(name, prefix = nil, partial = false, _details = { }, _key = nil, _locals = [])
+    def find_templates(name, prefix = nil, partial = false, _details = {}, _key = nil, _locals = [])
       name.prepend("_") if partial
       path = [prefix, name].join("/")
       template = find_template(name, path)

example_app_generator/spec/verify_mailer_preview_path_spec.rb

@@ -10,7 +10,7 @@ def ==(str)
 
   def as_commandline(ops)
     cmd, ops = ops.reverse
-    ops ||= { }
+    ops ||= {}
     cmd_parts = ops.map { |k, v| "#{k}=#{v}" } << cmd << '2>&1'
     cmd_parts.join(' ')
   end

lib/generators/rspec/scaffold/scaffold_generator.rb

@@ -109,7 +109,7 @@ def raw_value_for(attribute)
         when :string
           attribute.name.titleize
         when :integer, :float
-          @attribute_id_map ||= { }
+          @attribute_id_map ||= {}
           @attribute_id_map[attribute] ||= @attribute_id_map.keys.size.next + attribute.default
         else
           attribute.default

lib/rspec/rails/example/view_example_group.rb

@@ -16,7 +16,7 @@ module ViewExampleGroup
       # @private
       module StubResolverCache
         def self.resolver_for(hash)
-          @resolvers ||= { }
+          @resolvers ||= {}
           @resolvers[hash] ||= ActionView::FixtureResolver.new(hash)
         end
       end
@@ -63,7 +63,7 @@ module ExampleMethods
         #         # ...
         #       end
         #     end
-        def render(options = { }, local_assigns = { }, &block)
+        def render(options = {}, local_assigns = {}, &block)
           options = _default_render_options if Hash === options && options.empty?
           super(options, local_assigns, &block)
         end
@@ -189,7 +189,7 @@ def _include_controller_helpers
 
           controller.controller_path = _controller_path
 
-          path_params_to_merge = { }
+          path_params_to_merge = {}
           path_params_to_merge[:controller] = _controller_path
           path_params_to_merge[:action] = _inferred_action unless _inferred_action =~ /^_/
 

lib/rspec/rails/matchers/be_a_new.rb

@@ -45,7 +45,7 @@ def failure_message
       private
 
         def attributes
-          @attributes ||= { }
+          @attributes ||= {}
         end
 
         def attributes_match?(actual)

lib/rspec/rails/matchers/have_http_status.rb

@@ -46,7 +46,7 @@ def as_test_response(obj)
               resp.headers.clear
               resp.headers.merge!(obj.response_headers)
               resp.body    = obj.body
-              resp.request = ActionDispatch::Request.new({ })
+              resp.request = ActionDispatch::Request.new({})
             end
             ::ActionDispatch::TestResponse.from_response(obj)
           else

lib/rspec/rails/matchers/routing_matchers.rb

@@ -9,7 +9,7 @@ module RoutingMatchers
         class RouteToMatcher < RSpec::Rails::Matchers::BaseMatcher
           def initialize(scope, *expected)
             @scope = scope
-            @expected = expected[1] || { }
+            @expected = expected[1] || {}
             if Hash === expected[0]
               @expected.merge!(expected[0])
             else

lib/rspec/rails/view_assigns.rb

@@ -38,7 +38,7 @@ def _assigns
     private
 
       def _encapsulated_assigns
-        @_encapsulated_assigns ||= { }
+        @_encapsulated_assigns ||= {}
       end
     end
   end

lib/rspec/rails/view_spec_methods.rb

@@ -38,7 +38,7 @@ def extra_params=(hash)
           #     controller.extra_params
           #     # => { :id => 4 }
           def extra_params
-            @extra_params ||= { }
+            @extra_params ||= {}
             @extra_params.dup.freeze
           end
         end

spec/rspec/rails/configuration_spec.rb

@@ -20,7 +20,7 @@
   end
 
   shared_examples_for "adds setting" do |accessor, opts|
-    opts ||= { }
+    opts ||= {}
     default_value = opts[:default]
     alias_setting = opts[:alias_with]
     query_method = "#{accessor}?".to_sym

spec/rspec/rails/example/mailer_example_group_spec.rb

@@ -4,7 +4,7 @@ module ::Rails; end
     before do
       allow(Rails).to receive_message_chain(:application, :routes, :url_helpers).and_return(Rails)
       allow(Rails.application).to receive(:config).and_return(double("Rails.application.config").as_null_object)
-      allow(Rails).to receive_message_chain(:configuration, :action_mailer, :default_url_options).and_return({ })
+      allow(Rails).to receive_message_chain(:configuration, :action_mailer, :default_url_options).and_return({})
     end
 
     it_behaves_like "an rspec-rails example group mixin", :mailer,

spec/rspec/rails/example/view_example_group_spec.rb

@@ -123,11 +123,11 @@ def self.helper(*); end # Stub method
             def received
               @received ||= []
             end
-            def render(options = { }, local_assigns = { }, &block)
+            def render(options = {}, local_assigns = {}, &block)
               received << [options, local_assigns, block]
             end
             def _assigns
-              { }
+              {}
             end
           end
           include local
@@ -140,39 +140,39 @@ def _default_file_to_render; end # Stub method
         it "sends render(:template => (described file)) to the view" do
           allow(view_spec).to receive(:_default_file_to_render) { "widgets/new" }
           view_spec.render
-          expect(view_spec.received.first).to eq([{template: "widgets/new"}, { }, nil])
+          expect(view_spec.received.first).to eq([{template: "widgets/new"}, {}, nil])
         end
 
         it "converts the filename components into render options" do
           allow(view_spec).to receive(:_default_file_to_render) { "widgets/new.en.html.erb" }
           view_spec.render
-          expect(view_spec.received.first).to eq([{template: "widgets/new", locales: ['en'], formats: [:html], handlers: ['erb']}, { }, nil])
+          expect(view_spec.received.first).to eq([{template: "widgets/new", locales: ['en'], formats: [:html], handlers: ['erb']}, {}, nil])
         end
 
         it "converts the filename with variant into render options" do
           allow(view_spec).to receive(:_default_file_to_render) { "widgets/new.en.html+fancy.erb" }
           view_spec.render
-          expect(view_spec.received.first).to eq([{template: "widgets/new", locales: ['en'], formats: [:html], handlers: ['erb'], variants: ['fancy']}, { }, nil])
+          expect(view_spec.received.first).to eq([{template: "widgets/new", locales: ['en'], formats: [:html], handlers: ['erb'], variants: ['fancy']}, {}, nil])
         end
 
         it "converts the filename without format into render options" do
           allow(view_spec).to receive(:_default_file_to_render) { "widgets/new.en.erb" }
           view_spec.render
-          expect(view_spec.received.first).to eq([{template: "widgets/new", locales: ['en'], handlers: ['erb']}, { }, nil])
+          expect(view_spec.received.first).to eq([{template: "widgets/new", locales: ['en'], handlers: ['erb']}, {}, nil])
         end
       end
 
       context "given a string" do
         it "sends string as the first arg to render" do
           view_spec.render('arbitrary/path')
-          expect(view_spec.received.first).to eq(["arbitrary/path", { }, nil])
+          expect(view_spec.received.first).to eq(["arbitrary/path", {}, nil])
         end
       end
 
       context "given a hash" do
         it "sends the hash as the first arg to render" do
           view_spec.render(foo: 'bar')
-          expect(view_spec.received.first).to eq([{foo: "bar"}, { }, nil])
+          expect(view_spec.received.first).to eq([{foo: "bar"}, {}, nil])
         end
       end
     end
@@ -188,7 +188,7 @@ def controller
       end
 
       it 'delegates to the controller' do
-        expect(view_spec.controller).to receive(:params).and_return({ })
+        expect(view_spec.controller).to receive(:params).and_return({})
         view_spec.params[:foo] = 1
       end
     end

spec/rspec/rails/matchers/action_cable/have_broadcasted_to_spec.rb

@@ -12,7 +12,7 @@ def initialize(id)
       @id = id
     end
 
-    def to_global_id(_options = { })
+    def to_global_id(_options = {})
       @global_id ||= GlobalID.create(self, app: "rspec-suite")
     end
   end

spec/rspec/rails/matchers/active_job_spec.rb

@@ -20,7 +20,7 @@ def ==(comparison_object)
       (GlobalIdModel === comparison_object) && (id == comparison_object.id)
     end
 
-    def to_global_id(_options = { })
+    def to_global_id(_options = {})
       @global_id ||= GlobalID.create(self, app: "rspec-suite")
     end
   end

spec/rspec/rails/matchers/be_routable_spec.rb

@@ -10,7 +10,7 @@
 
   context "with should" do
     it "passes if routes recognize the path" do
-      allow(routes).to receive(:recognize_path) { { } }
+      allow(routes).to receive(:recognize_path) { {} }
       expect do
         expect({get: "/a/path"}).to be_routable
       end.to_not raise_error

spec/rspec/rails/matchers/have_http_status_spec.rb

@@ -1,15 +1,15 @@
 RSpec.describe "have_http_status" do
-  def create_response(opts = { })
+  def create_response(opts = {})
     ActionDispatch::TestResponse.new(opts.fetch(:status)).tap { |x|
-      x.request = ActionDispatch::Request.new({ })
+      x.request = ActionDispatch::Request.new({})
     }
   end
 
   shared_examples_for "supports different response instances" do
     context "given an ActionDispatch::Response" do
       it "returns true for a response with the same code" do
         response = ::ActionDispatch::Response.new(code).tap { |x|
-          x.request = ActionDispatch::Request.new({ })
+          x.request = ActionDispatch::Request.new({})
         }
 
         expect(matcher.matches?(response)).to be(true)
@@ -19,7 +19,7 @@ def create_response(opts = { })
     context "given an ActionDispatch::TestResponse" do
       it "returns true for a response with the same code" do
         response = ::ActionDispatch::TestResponse.new(code).tap { |x|
-          x.request = ActionDispatch::Request.new({ })
+          x.request = ActionDispatch::Request.new({})
         }
 
         expect(matcher.matches?(response)).to be(true)
@@ -31,7 +31,7 @@ def create_response(opts = { })
         response = instance_double(
           '::Capybara::Session',
           status_code: code,
-          response_headers: { },
+          response_headers: {},
           body: ""
         )
 
@@ -440,7 +440,7 @@ def create_response(opts = { })
         splitter = RSpec::Support::StdErrSplitter.new(previous_stderr)
         $stderr = splitter
         response = ::ActionDispatch::Response.new(code).tap { |x|
-          x.request = ActionDispatch::Request.new({ })
+          x.request = ActionDispatch::Request.new({})
         }
         expect(matcher.matches?(response)).to be(true)
         expect(splitter.has_output?).to be false

spec/rspec/rails/matchers/route_to_spec.rb

@@ -13,21 +13,21 @@ def assert_recognizes(*)
   end
 
   it "delegates to assert_recognizes" do
-    expect(self).to receive(:assert_recognizes).with({"these" => "options"}, {method: :get, path: "path"}, { })
+    expect(self).to receive(:assert_recognizes).with({"these" => "options"}, {method: :get, path: "path"}, {})
     expect({get: "path"}).to route_to("these" => "options")
   end
 
   context "with shortcut syntax" do
     it "routes with extra options" do
-      expect(self).to receive(:assert_recognizes).with({controller: "controller", action: "action", extra: "options"}, {method: :get, path: "path"}, { })
+      expect(self).to receive(:assert_recognizes).with({controller: "controller", action: "action", extra: "options"}, {method: :get, path: "path"}, {})
       expect(get("path")).to route_to("controller#action", extra: "options")
     end
 
     it "routes without extra options" do
       expect(self).to receive(:assert_recognizes).with(
         {controller: "controller", action: "action"},
         {method: :get, path: "path"},
-        { }
+        {}
       )
       expect(get("path")).to route_to("controller#action")
     end