Compatibility with compound matchers

Author: ka8725

lib/rspec/rails/matchers/send_email.rb

@@ -9,18 +9,20 @@ module Matchers
       #
       # @see RSpec::Rails::Matchers#send_email
       class SendEmail < RSpec::Rails::Matchers::BaseMatcher
+        # @api private
+        # Define the email attributes that should be included in the inspection output.
         INSPECT_EMAIL_ATTRIBUTES = %i[subject from to cc bcc].freeze
 
         def initialize(criteria)
           @criteria = criteria
         end
 
-        # @private
+        # @api private
         def supports_value_expectations?
           false
         end
 
-        # @private
+        # @api private
         def supports_block_expectations?
           true
         end
@@ -31,17 +33,8 @@ def matches?(block)
           @matched_emails.one?
         end
 
-        private
-
-        def diffable?
-          true
-        end
-
-        def match_when_negated(block)
-          define_matched_emails(block)
-          @matched_emails.empty?
-        end
-
+        # @api private
+        # @return [String]
         def failure_message
           result =
             if multiple_match?
@@ -52,10 +45,18 @@ def failure_message
           "#{result}#{sent_emails_message}"
         end
 
+        # @api private
+        # @return [String]
         def failure_message_when_negated
           "Expected not to send an email but it was sent."
         end
 
+        private
+
+        def diffable?
+          true
+        end
+
         def deliveries
           ActionMailer::Base.deliveries
         end
@@ -68,11 +69,7 @@ def define_matched_emails(block)
           after = deliveries
 
           @diff = after - before
-          @matched_emails = select_matching(@diff)
-        end
-
-        def select_matching(emails)
-          @criteria.empty? ? emails : emails.select(&method(:matched_email?))
+          @matched_emails = @diff.select(&method(:matched_email?))
         end
 
         def matched_email?(email)

spec/rspec/rails/matchers/send_email_spec.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 RSpec.describe "send_email" do
   let(:mailer) do
     Class.new(ActionMailer::Base) do
@@ -37,7 +35,7 @@ def test_email
     }.to send_email
   end
 
-  it "has a negated version" do
+  it "with with to_not" do
     expect {
       mailer.test_email.deliver_now
     }.to_not send_email(
@@ -83,4 +81,88 @@ def test_email
       - subject: Test email, from: ["[email protected]"], to: ["[email protected]"], cc: ["[email protected]"], bcc: ["[email protected]"]
     MSG
   end
+
+  context "with compound matching" do
+    it "works when both matchings pass" do
+      expect {
+        expect {
+          mailer.test_email.deliver_now
+        }.to send_email(to: "[email protected]").and send_email(from: "[email protected]")
+      }.to_not raise_error
+    end
+
+    it "works when first matching fails" do
+      expect {
+        expect {
+          mailer.test_email.deliver_now
+        }.to send_email(to: "[email protected]").and send_email(to: "[email protected]")
+      }.to raise_error(RSpec::Expectations::ExpectationNotMetError, <<~MSG.strip)
+        No matching emails were sent.
+
+        The following emails were sent:
+        - subject: Test email, from: ["[email protected]"], to: ["[email protected]"], cc: ["[email protected]"], bcc: ["[email protected]"]
+      MSG
+    end
+
+    it "works when second matching fails" do
+      expect {
+        expect {
+          mailer.test_email.deliver_now
+        }.to send_email(to: "[email protected]").and send_email(to: "[email protected]")
+      }.to raise_error(RSpec::Expectations::ExpectationNotMetError, <<~MSG.strip)
+        No matching emails were sent.
+
+        The following emails were sent:
+        - subject: Test email, from: ["[email protected]"], to: ["[email protected]"], cc: ["[email protected]"], bcc: ["[email protected]"]
+      MSG
+    end
+  end
+
+  context "with a custom negated version defined" do
+    before { RSpec::Matchers.define_negated_matcher :not_send_email, :send_email }
+
+    it "works with a negated version" do
+      expect {
+        mailer.test_email.deliver_now
+      }.to not_send_email(
+        from: "[email protected]"
+      )
+    end
+
+    it "fails with a clear message" do
+      expect {
+        expect { mailer.test_email.deliver_now }.to not_send_email(from: "[email protected]")
+      }.to raise_error(RSpec::Expectations::ExpectationNotMetError, "Expected not to send an email but it was sent.")
+    end
+
+    context "with a compound negated version" do
+      it "works when both matchings pass" do
+        expect {
+          expect {
+            mailer.test_email.deliver_now
+          }.to not_send_email(to: "[email protected]").and not_send_email(from: "[email protected]")
+        }.to_not raise_error
+      end
+
+      it "works when first matching fails" do
+        expect {
+          expect {
+            mailer.test_email.deliver_now
+          }.to not_send_email(to: "[email protected]").and send_email(to: "[email protected]")
+        }.to raise_error(RSpec::Expectations::ExpectationNotMetError, a_string_including(<<~MSG.strip))
+          Expected not to send an email but it was sent.
+        MSG
+      end
+
+      it "works when second matching fails" do
+        expect {
+          expect {
+            mailer.test_email.deliver_now
+          }.to send_email(to: "[email protected]").and not_send_email(to: "[email protected]")
+        }.to raise_error(RSpec::Expectations::ExpectationNotMetError, a_string_including(<<~MSG.strip))
+          Expected not to send an email but it was sent.
+        MSG
+      end
+    end
+  end
 end