Skip to content

Commit 1dc7b46

Browse files
committed
fixup! Copy over the comment to the example app generator
1 parent e7aff07 commit 1dc7b46

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

Gemfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,10 @@ MAJOR =
3333
end
3434

3535
if MAJOR >= 6
36-
# sqlite3 is a optional, unspecified, dependancy and Rails 6.0 only supports `~> 1.4`
36+
# sqlite3 is an optional, unspecified, dependency and Rails 6.0 only supports `~> 1.4`
3737
gem 'sqlite3', '~> 1.4', platforms: [:ruby]
3838
else
39-
# Similarly Rails 5.0 only supports '~> 1.3.6', with 5.1 and 5.2 supporting "~> 1.3", ">= 1.3.6"
39+
# Similarly, Rails 5.0 only supports '~> 1.3.6'. Rails 5.1-5.2 support '~> 1.3', '>= 1.3.6'
4040
gem 'sqlite3', '~> 1.3.6', platforms: [:ruby]
4141
end
4242

example_app_generator/generate_app.rb

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,10 @@
2525
gsub_file "Gemfile", /.*bootsnap.*/, ''
2626

2727
if Rails::VERSION::STRING >= '6'
28-
# Rails 6.0 specify '~> 1.4' directly in the adapter.
29-
# This is to prevent breakages when `sqlite3` 1.5.x is out.
28+
# sqlite3 is an optional, unspecified, dependency and Rails 6.0 only supports `~> 1.4`
3029
gsub_file "Gemfile", /.*gem..sqlite3.*/, "gem 'sqlite3', '~> 1.4'"
3130
else
32-
# Rails 5.0 specify '~> 1.3.6', 5.1 and 5.2 - "~> 1.3", ">= 1.3.6" directly in the adapter.
31+
# Similarly, Rails 5.0 only supports '~> 1.3.6'. Rails 5.1-5.2 support '~> 1.3', '>= 1.3.6'
3332
gsub_file "Gemfile", /.*gem..sqlite3.*/, "gem 'sqlite3', '~> 1.3.6'"
3433
end
3534

0 commit comments

Comments
 (0)