Merge pull request #1959 from rspec/rails-5-2-compat

Rails 5.2 compatability

Author: JonRowe

.travis.yml

@@ -83,6 +83,8 @@ matrix:
       env: RAILS_VERSION=5-0-stable
     - rvm: 2.5.1
       env: RAILS_VERSION=5.1.0
+    - rvm: 2.4.2
+      env: RAILS_VERSION=5.2.0.rc1
   exclude:
     # 3.0.x is not supported on MRI 2.0+
     - rvm: 2.0.0

Gemfile

@@ -47,7 +47,7 @@ end
 
 # Capybara versions that support RSpec 3 only support RUBY_VERSION >= 1.9.3
 if RUBY_VERSION >= '1.9.3'
-  if /5(\.|-)1/ === RAILS_VERSION || "master" == RAILS_VERSION
+  if /5(\.|-)[1-9]\d*/ === RAILS_VERSION || "master" == RAILS_VERSION
     gem 'capybara', '~> 2.13', :require => false
   else
     gem 'capybara', '~> 2.2.0', :require => false

example_app_generator/config/initializers/sqlite3_fix.rb

@@ -0,0 +1,3 @@
+if Rails.application.config.respond_to?(:active_record)
+  Rails.application.config.active_record.sqlite3.represent_boolean_as_integer = true
+end

example_app_generator/generate_app.rb

@@ -11,6 +11,7 @@
   'travis_retry_bundle_install.sh'
 )
 function_script_file = File.join(rspec_rails_repo_path, 'script/functions.sh')
+sqlite_initializer = File.join(rspec_rails_repo_path, "example_app_generator/config/initializers/sqlite3_fix.rb")
 
 in_root do
   prepend_to_file "Rakefile", "require 'active_support/all'"
@@ -27,6 +28,10 @@
     append_to_file('Gemfile', "gem 'rails-controller-testing', :git => 'https://github.com/rails/rails-controller-testing'\n")
   end
 
+  if Rails::VERSION::STRING >= '5.2.0'
+    copy_file sqlite_initializer, 'config/initializers/sqlite3_fix.rb'
+  end
+
   # Nokogiri version is pinned in rspec-rails' Gemfile since it tend to cause installation problems
   # on Travis CI, so we pin nokogiri in this example app also.
   append_to_file 'Gemfile', "gem 'nokogiri', '#{Nokogiri::VERSION}'\n"

example_app_generator/log/development.log

@@ -5,6 +5,12 @@ def require_file_stub(name)
 end
 
 ENV['RAILS_ENV'] ||= 'development'
+# Pick the frameworks you want:
+begin
+  require "active_storage"
+  require "active_storage/engine"
+rescue LoadError
+end
 
 require_file_stub 'config/environment' do
   # Load the Rails application.

example_app_generator/spec/support/default_preview_path

@@ -51,7 +51,8 @@ def app
           require 'capybara'
           require 'action_dispatch/system_test_case'
         # rubocop:disable Lint/HandleExceptions
-        rescue LoadError
+        rescue LoadError => e
+          p e
           # rubocop:enable Lint/HandleExceptions
           abort """
             System test integration requires Rails >= 5.1 and has a hard